From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 18CB32BC6 for ; Wed, 1 Jun 2016 09:55:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 01 Jun 2016 00:55:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,400,1459839600"; d="scan'208";a="712087688" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by FMSMGA003.fm.intel.com with ESMTP; 01 Jun 2016 00:55:29 -0700 Date: Wed, 1 Jun 2016 15:58:21 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Cc: "dev@dpdk.org" , "Xie, Huawei" , "rich.lane@bigswitch.com" , "mst@redhat.com" , "nakajima.yoshihiro@lab.ntt.co.jp" , "p.fedin@samsung.com" , "ann.zhuangyanying@huawei.com" , "mukawa@igel.co.jp" , "nhorman@tuxdriver.com" Message-ID: <20160601075821.GA3679@yliu-dev.sh.intel.com> References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <1464605739-140761-1-git-send-email-jianfeng.tan@intel.com> <1464605739-140761-3-git-send-email-jianfeng.tan@intel.com> <20160601073814.GD10038@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 07:55:32 -0000 On Wed, Jun 01, 2016 at 07:44:33AM +0000, Tan, Jianfeng wrote: > Hi Yuanhan, > > > -----Original Message----- > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > Sent: Wednesday, June 1, 2016 3:38 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; Xie, Huawei; rich.lane@bigswitch.com; mst@redhat.com; > > nakajima.yoshihiro@lab.ntt.co.jp; p.fedin@samsung.com; > > ann.zhuangyanying@huawei.com; mukawa@igel.co.jp; > > nhorman@tuxdriver.com > > Subject: Re: [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup > > > > On Mon, May 30, 2016 at 10:55:33AM +0000, Jianfeng Tan wrote: > > > Abstract vring hdr desc init as an inline method. > > > > What's this patch for then? In your last version, it will be invoked > > twice, but it turned out to be wrong. So, why keeping this change? > > I didn't see it improves anything. > > > > Yes, for now, only one version is kept because the position to call this function is changed. And I think this segment of code functions as a special purpose, which can be abstracted as a function, make sense? Yeah, maybe. But idealy, we should move it to tx_queue_setup() function. Let's see what we might do after applying Huawei's rx/tx split patch: it needs a while (I saw bugs). --yliu