From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 527062B83
 for <dev@dpdk.org>; Thu,  2 Jun 2016 08:43:02 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 01 Jun 2016 23:43:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,405,1459839600"; d="scan'208";a="967237390"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga001.jf.intel.com with ESMTP; 01 Jun 2016 23:43:01 -0700
Date: Thu, 2 Jun 2016 14:43:04 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20160602064304.GA12261@yliu-dev.sh.intel.com>
References: <1462323027-91942-1-git-send-email-huawei.xie@intel.com>
 <1464599180-76004-1-git-send-email-huawei.xie@intel.com>
 <20160601071546.GC10038@yliu-dev.sh.intel.com>
 <C37D651A908B024F974696C65296B57B4C7C1F7D@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <C37D651A908B024F974696C65296B57B4C7C1F7D@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2016 06:43:02 -0000

On Thu, Jun 02, 2016 at 06:38:49AM +0000, Xie, Huawei wrote:
> On 6/1/2016 3:13 PM, Yuanhan Liu wrote:
> > On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote:
> >> We keep a common vq structure, containing only vq related fields,
> >> and then split others into RX, TX and control queue respectively.
> >>
> >> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> >> ---
> >> v2:
> >> - don't split virtio_dev_rx/tx_queue_setup
> >> v3:
> >> - fix some 80 char warnings
> >> - fix other newer version checkpatch warnings
> >> - remove '\n' in PMD_RX_LOG
> > Weird, I still saw them.
> 
> Maybe missed this.
> 
> 
> >
> > Besides that, I found a crash issue with this patch applied. You could
> > easily reproduce it by:
> >
> >     testpmd> start tx_first
> >     testpmd> quit
> >
> >     [82774.055297] testpmd[9661]: segfault at 94 ip 00000000004f7ef0 sp 00007ffcb1fa
> >     66c0 error 4 in testpmd[400000+25b000]
> >     ./t.pmd: line 11:  9661 Segmentation fault           (core dumped) $RTE_SDK/$RTE
> >     _TARGET/app/testpmd -c 0x1f -n 4 -- --nb-cores=4 -i --disable-hw-vlan --txqflags
> >      0xf00 --rxq=$nr_queues --txq=$nr_queues --rxd=256 --txd=256
> >
> > 	--yliu
> >
> 
> Couldn't reproduce. Seems like resource free issue. Do you test with
> multiple queues?

Nope, nr_queues is 1 by default.

	--yliu