From: Neil Horman <nhorman@tuxdriver.com>
To: Matthew Hall <mhall@mhcomputing.net>
Cc: "Wiles, Keith" <keith.wiles@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Panu Matilainen <pmatilai@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [RFC] Yet another option for DPDK options
Date: Thu, 2 Jun 2016 18:34:58 -0400 [thread overview]
Message-ID: <20160602223458.GA24257@neilslaptop.think-freely.org> (raw)
In-Reply-To: <20160602205355.GB24543@mhcomputing.net>
On Thu, Jun 02, 2016 at 01:53:55PM -0700, Matthew Hall wrote:
> On Thu, Jun 02, 2016 at 04:08:37PM -0400, Neil Horman wrote:
> > struct key_vals {
> > char *key;
> > union {
> > ulong longval;
> > void *ptrval;
> > } value;
> > };
> >
> > struct config {
> > size_t count;
> > struct key_vals kvp[0];
> > };
>
> This sort of code is very 1970s / ioctl / messy binary. And doesn't buy any
> performance advantage because it's just for config.
>
What!? I can't even parse that sentence. Of course its just for config, we're
talking about a configuration structure. If you want to make it more
complex/heirarchical/whatever, fine, propose a way to do that that isnt ABI
variant in response to config additions. Its just a starting point.
> Something that looks more like sysctl MIBs with hierarchical names or like
> JSON w/ a hierarchy of hash tables and arrays is much less user-hostile.
>
> https://www.freebsd.org/cgi/man.cgi?sysctl(3)
>
I can't even begin to understand what you're after here. sysctl provides a
heirarchy in _exactly_ the same way that I just proposed, by texual consistency
in naming.
> http://json-c.github.io/json-c/json-c-0.12/doc/html/json__object_8h.html
>
So, this is a fine interface to convert text config to a code format, but thats
a decision that application should be making, not something dpdk should mandate
Neil
> Matthew.
>
next prev parent reply other threads:[~2016-06-02 22:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 15:00 Wiles, Keith
2016-06-01 15:46 ` Matthew Hall
2016-06-01 16:08 ` Wiles, Keith
2016-06-01 15:58 ` Jay Rolette
2016-06-01 16:18 ` Bruce Richardson
2016-06-01 16:21 ` Arnon Warshavsky
2016-06-01 18:13 ` Wiles, Keith
2016-06-01 18:31 ` Stephen Hemminger
2016-06-03 10:07 ` Yerden Zhumabekov
2016-06-01 18:51 ` Thomas Monjalon
2016-06-02 9:19 ` Marc
2016-06-02 7:56 ` Yuanhan Liu
2016-06-02 10:41 ` Neil Horman
2016-06-02 13:19 ` Thomas Monjalon
2016-06-02 13:53 ` Wiles, Keith
2016-06-02 17:11 ` Neil Horman
2016-06-02 19:33 ` Wiles, Keith
2016-06-02 19:41 ` Wiles, Keith
2016-06-02 20:08 ` Neil Horman
2016-06-02 20:53 ` Matthew Hall
2016-06-02 22:34 ` Neil Horman [this message]
2016-06-03 2:17 ` Matthew Hall
2016-06-03 9:57 ` Bruce Richardson
2016-06-03 10:06 ` Bruce Richardson
2016-06-03 12:03 ` Neil Horman
2016-06-03 10:29 ` Bruce Richardson
2016-06-03 11:01 ` Bruce Richardson
2016-06-03 11:50 ` Neil Horman
2016-06-03 12:01 ` Arnon Warshavsky
2016-06-03 12:53 ` Panu Matilainen
2016-06-03 14:31 ` Arnon Warshavsky
2016-06-03 16:04 ` Wiles, Keith
2016-06-03 16:10 ` Wiles, Keith
2016-06-03 17:44 ` Neil Horman
2016-06-03 18:29 ` Wiles, Keith
2016-06-03 18:38 ` Neil Horman
2016-06-03 18:52 ` Arnon Warshavsky
2016-06-03 19:00 ` Wiles, Keith
2016-06-03 19:07 ` Wiles, Keith
2016-06-03 19:18 ` Neil Horman
2016-06-03 19:23 ` Wiles, Keith
2016-06-03 19:28 ` Arnon Warshavsky
2016-06-03 21:42 ` Matthew Hall
2016-06-03 21:41 ` Matthew Hall
2016-06-05 0:19 ` Neil Horman
2016-06-03 21:40 ` Matthew Hall
2016-06-03 21:38 ` Matthew Hall
2016-06-03 12:14 ` Panu Matilainen
2016-06-02 20:51 ` Matthew Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602223458.GA24257@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=keith.wiles@intel.com \
--cc=mhall@mhcomputing.net \
--cc=olivier.matz@6wind.com \
--cc=pmatilai@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).