From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 510E3FE5 for ; Mon, 13 Jun 2016 11:51:19 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 13 Jun 2016 02:51:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="120843520" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 13 Jun 2016 02:51:17 -0700 Date: Mon, 13 Jun 2016 17:53:16 +0800 From: Yuanhan Liu To: dev@dpdk.org Cc: huawei.xie@intel.com Message-ID: <20160613095316.GQ10038@yliu-dev.sh.intel.com> References: <1465270376-16560-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465270376-16560-1-git-send-email-yuanhan.liu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix corrupted vdev tailq list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 09:51:19 -0000 On Tue, Jun 07, 2016 at 11:32:56AM +0800, Yuanhan Liu wrote: > There are two tailq lists, one for logging all vhost devices, another > one for logging vhost devices distributed on a specific core. However, > there is just one tailq entry, named "next", to chain the two list, > which is wrong and could result to a corrupted tailq list, that the > tailq list might always be non-empty: the entry is still there even > after you have invoked TAILQ_REMOVE several times. > > Fix it by introducing two tailq entries, one for each list. > > Fixes: 45657a5c6861 ("examples/vhost: use tailq to link vhost devices") > > Signed-off-by: Yuanhan Liu Applied to dpdk-next-virtio. --yliu