From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8C4EA2C5B for ; Mon, 13 Jun 2016 12:51:47 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 13 Jun 2016 03:51:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="996474879" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.58]) by orsmga002.jf.intel.com with SMTP; 13 Jun 2016 03:51:44 -0700 Received: by (sSMTP sendmail emulation); Mon, 13 Jun 2016 11:51:43 +0025 Date: Mon, 13 Jun 2016 11:51:43 +0100 From: Bruce Richardson To: Jingjing Wu Cc: helin.zhang@intel.com, dev@dpdk.org, yulong.pei@intel.com Message-ID: <20160613105143.GF13464@bricha3-MOBL3> References: <1464336345-20529-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464336345-20529-1-git-send-email-jingjing.wu@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] i40e: fix vlan filter in promiscuous mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 10:51:47 -0000 On Fri, May 27, 2016 at 04:05:45PM +0800, Jingjing Wu wrote: > Vlan filter didn't work if promiscuous mode is enabled. That is > because i40e driver uses MAC VLAN table for the l2 filtering and > internal switch. And the vlan table is disabled by default, till > the first time to add rule in vlan table. > This patch fixed this issue to enable vlan filter by using vlan table. > > Fixes: 4861cde46116 (i40e: new poll mode driver) > Signed-off-by: Jingjing Wu > --- Hi Jingjing, can you please clarify this commit message a little to give a little more detail on how the current setup stops the feature from working, and how the fix removes the problem. Thanks, /Bruce