DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, thomas.monjalon@6wind.com
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"johndale@cisco.com" <johndale@cisco.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"arnon@qwilt.com" <arnon@qwilt.com>,
	"rolette@infinite.io" <rolette@infinite.io>,
	"Chen, Jing D" <jing.d.chen@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused Rx error flags
Date: Mon, 13 Jun 2016 14:25:31 +0100	[thread overview]
Message-ID: <20160613132530.GC15736@bricha3-MOBL3> (raw)
In-Reply-To: <575EABE5.6010807@6wind.com>

On Mon, Jun 13, 2016 at 02:49:41PM +0200, Olivier Matz wrote:
> Hi Konstantin,
> 
> On 06/13/2016 02:42 PM, Ananyev, Konstantin wrote:
> > 
> > Hi Olivier,
> > 
> >>> -----Original Message-----
> >>> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> >>> Sent: Monday, May 23, 2016 8:56 AM
> >>> To: dev@dpdk.org
> >>> Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.com; rolette@infinite.io; Chen, Jing D; Wu, Jingjing
> >>> Subject: [PATCH] mbuf: remove unused Rx error flags
> >>>
> >>> Following the discussions from:
> >>> http://dpdk.org/ml/archives/dev/2015-July/021721.html
> >>> http://dpdk.org/ml/archives/dev/2016-April/038143.html
> >>>
> >>> The value of these flags is 0, making them useless. Today, no example
> >>> application checks them on Rx, and only few drivers sets them and
> >>> silently give wrong packets to the application, which should not happen.
> >>>
> >>> This patch removes the unused flags from rte_mbuf and their use in the
> >>> drivers. The i40e and fm10k are kept as they are today and should be
> >>> fixed to drop bad packets. The enic driver is managed by its maintainer
> >>> in another patch.
> >>>
> >>> Fixes: c22265f6 ("mbuf: add new packet flags for i40e")
> >>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >>> ---
> >>
> >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > 
> > 
> > Just a note, I think you'll need to rebase your patch with latest code.
> > enic PMD fails to compile.
> 
> Indeed, this patch should be applied after John's enic series. Latest
> one is there:
> http://dpdk.org/ml/archives/dev/2016-June/040183.html
> 
> Please Bruce/Thomas, check this dependency before applying.
> 
That patchset is already applied to next-net so this patch applies cleanly and
compiles ok there.
Thomas, you ok for me just to apply this patch to next-net also?

/Bruce

  reply	other threads:[~2016-06-13 13:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 12:25 [dpdk-dev] removing mbuf " Olivier Matz
2016-04-29 17:47 ` John Daley (johndale)
2016-04-29 18:16 ` Don Provan
2016-04-29 18:24   ` Jay Rolette
2016-04-29 20:00     ` Arnon Warshavsky
2016-04-29 20:57       ` Olivier MATZ
2016-04-30  1:41         ` Don Provan
2016-05-10  8:40           ` [dpdk-dev] [RFC] mbuf: remove unused rx " Olivier Matz
2016-05-12  1:32             ` John Daley (johndale)
2016-05-12  9:25               ` Olivier MATZ
2016-05-23  7:56                 ` [dpdk-dev] [PATCH] mbuf: remove unused Rx " Olivier Matz
2016-06-13 11:39                   ` Olivier Matz
2016-06-13 12:39                   ` Ananyev, Konstantin
2016-06-13 14:00                     ` Bruce Richardson
2016-06-13 12:42                   ` Ananyev, Konstantin
2016-06-13 12:49                     ` Olivier Matz
2016-06-13 13:25                       ` Bruce Richardson [this message]
2016-06-13 13:52                         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160613132530.GC15736@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jing.d.chen@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=johndale@cisco.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=rolette@infinite.io \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).