From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8752137B1 for ; Mon, 13 Jun 2016 15:25:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 13 Jun 2016 06:25:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="986400319" Received: from lculbert-sp4.amr.corp.intel.com ([10.252.8.8]) by fmsmga001.fm.intel.com with SMTP; 13 Jun 2016 06:25:35 -0700 Received: by (sSMTP sendmail emulation); Mon, 13 Jun 2016 14:25:31 +0025 Date: Mon, 13 Jun 2016 14:25:31 +0100 From: Bruce Richardson To: Olivier Matz , thomas.monjalon@6wind.com Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , "johndale@cisco.com" , "Zhang, Helin" , "arnon@qwilt.com" , "rolette@infinite.io" , "Chen, Jing D" , "Wu, Jingjing" Message-ID: <20160613132530.GC15736@bricha3-MOBL3> References: <57344C06.1030007@6wind.com> <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B6FDB0@irsmsx105.ger.corp.intel.com> <575EABE5.6010807@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <575EABE5.6010807@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused Rx error flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 13:25:42 -0000 On Mon, Jun 13, 2016 at 02:49:41PM +0200, Olivier Matz wrote: > Hi Konstantin, > > On 06/13/2016 02:42 PM, Ananyev, Konstantin wrote: > > > > Hi Olivier, > > > >>> -----Original Message----- > >>> From: Olivier Matz [mailto:olivier.matz@6wind.com] > >>> Sent: Monday, May 23, 2016 8:56 AM > >>> To: dev@dpdk.org > >>> Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.com; rolette@infinite.io; Chen, Jing D; Wu, Jingjing > >>> Subject: [PATCH] mbuf: remove unused Rx error flags > >>> > >>> Following the discussions from: > >>> http://dpdk.org/ml/archives/dev/2015-July/021721.html > >>> http://dpdk.org/ml/archives/dev/2016-April/038143.html > >>> > >>> The value of these flags is 0, making them useless. Today, no example > >>> application checks them on Rx, and only few drivers sets them and > >>> silently give wrong packets to the application, which should not happen. > >>> > >>> This patch removes the unused flags from rte_mbuf and their use in the > >>> drivers. The i40e and fm10k are kept as they are today and should be > >>> fixed to drop bad packets. The enic driver is managed by its maintainer > >>> in another patch. > >>> > >>> Fixes: c22265f6 ("mbuf: add new packet flags for i40e") > >>> Signed-off-by: Olivier Matz > >>> --- > >> > >> Acked-by: Konstantin Ananyev > > > > > > Just a note, I think you'll need to rebase your patch with latest code. > > enic PMD fails to compile. > > Indeed, this patch should be applied after John's enic series. Latest > one is there: > http://dpdk.org/ml/archives/dev/2016-June/040183.html > > Please Bruce/Thomas, check this dependency before applying. > That patchset is already applied to next-net so this patch applies cleanly and compiles ok there. Thomas, you ok for me just to apply this patch to next-net also? /Bruce