From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E1BA33978 for ; Mon, 13 Jun 2016 16:23:54 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 13 Jun 2016 07:23:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="120974863" Received: from lculbert-sp4.amr.corp.intel.com ([10.252.8.8]) by fmsmga004.fm.intel.com with SMTP; 13 Jun 2016 07:23:52 -0700 Received: by (sSMTP sendmail emulation); Mon, 13 Jun 2016 15:23:51 +0025 Date: Mon, 13 Jun 2016 15:23:51 +0100 From: Bruce Richardson To: John Daley Cc: dev@dpdk.org Message-ID: <20160613142351.GG15736@bricha3-MOBL3> References: <20160610092236.GA11860@bricha3-MOBL3> <1465666025-10159-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465666025-10159-1-git-send-email-johndale@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 1/2] enic: fix seg fault when releasing queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 14:23:55 -0000 On Sat, Jun 11, 2016 at 10:27:04AM -0700, John Daley wrote: > If device configuration failed due to a lack of resources, such as > if more queues are requested than are available, the queue release > functions are called with NULL pointers which were being dereferenced. > > Skip releasing queues if they are NULL pointers. > > Fixes: fefed3d1e62c ("enic: new driver") > Signed-off-by: John Daley Patchset applied to dpdk-next-net/rel_16_07 /Bruce