From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 283DE7E24 for ; Tue, 14 Jun 2016 12:14:20 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 14 Jun 2016 03:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="987077965" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.72]) by fmsmga001.fm.intel.com with SMTP; 14 Jun 2016 03:14:18 -0700 Received: by (sSMTP sendmail emulation); Tue, 14 Jun 2016 11:14:17 +0025 Date: Tue, 14 Jun 2016 11:14:16 +0100 From: Bruce Richardson To: Helin Zhang Cc: dev@dpdk.org Message-ID: <20160614101416.GA18600@bricha3-MOBL3> References: <1462438424-22574-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-2-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464070989-32726-2-git-send-email-helin.zhang@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 01/15] i40e/base: remove HMC AQ APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 10:14:20 -0000 On Tue, May 24, 2016 at 02:22:55PM +0800, Helin Zhang wrote: > HMC AQ APIs were removed from the latest datasheet, and > hence remove its implementations and relevant. > > Signed-off-by: Helin Zhang Still haven't clarified what HMC stands for.... :-) Looking up an old data sheet, I guess it stands for "Host Memory Cache", is that correct? Please expand out all acronyms in the commit message unless they are really common ones. Regards, /Bruce PS: Suggested rule of thumb - unless it's called out for a capitalization check in scripts/check-git-log.sh, the acronym is not common enough, and you need to expand it out.