Re: [dpdk-dev] [PATCH v2 15/15] i40e/base: add capability of disabling all link

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, May 24, 2016 at 02:23:09PM +0800, Helin Zhang wrote:
> It adds a flag, which can be used to tell the firmware to
> disable the link on all ports.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  doc/guides/rel_notes/release_16_07.rst  | 4 ++++
>  drivers/net/i40e/Makefile               | 2 +-
>  drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/release_16_07.rst b/doc/guides/rel_notes/release_16_07.rst
> index 30e78d4..304aba6 100644
> --- a/doc/guides/rel_notes/release_16_07.rst
> +++ b/doc/guides/rel_notes/release_16_07.rst
> @@ -47,6 +47,10 @@ New Features
>    * Dropped specific Xen Dom0 code.
>    * Dropped specific anonymous mempool code in testpmd.
>  
> +* **Updated the i40e base driver.**
> +
> +  It updated the i40e base driver, which includes supporting new devices IDs.
> +
>  
While it's good to see the documentation updates included in with code changes,
this is not correct for this set. The documentation update does not belong with
the change to "firmware to disable the link on all ports". The documentation
update is for the patch, not the last patch, so it needs to go as a separate
patch.
Therefore this patch needs to be split in two - one patch for the base code
change, and a second to update the docs for the base code update as a whole

/Bruce