From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B28DD960A for ; Tue, 14 Jun 2016 15:48:06 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 14 Jun 2016 06:48:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="975384724" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.72]) by orsmga001.jf.intel.com with SMTP; 14 Jun 2016 06:48:03 -0700 Received: by (sSMTP sendmail emulation); Tue, 14 Jun 2016 14:48:02 +0025 Date: Tue, 14 Jun 2016 14:48:02 +0100 From: Bruce Richardson To: Helin Zhang Cc: dev@dpdk.org Message-ID: <20160614134802.GF18600@bricha3-MOBL3> References: <1462438424-22574-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-16-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464070989-32726-16-git-send-email-helin.zhang@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 15/15] i40e/base: add capability of disabling all link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 13:48:07 -0000 On Tue, May 24, 2016 at 02:23:09PM +0800, Helin Zhang wrote: > It adds a flag, which can be used to tell the firmware to > disable the link on all ports. > > Signed-off-by: Helin Zhang > --- > doc/guides/rel_notes/release_16_07.rst | 4 ++++ > drivers/net/i40e/Makefile | 2 +- > drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++ > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_16_07.rst b/doc/guides/rel_notes/release_16_07.rst > index 30e78d4..304aba6 100644 > --- a/doc/guides/rel_notes/release_16_07.rst > +++ b/doc/guides/rel_notes/release_16_07.rst > @@ -47,6 +47,10 @@ New Features > * Dropped specific Xen Dom0 code. > * Dropped specific anonymous mempool code in testpmd. > > +* **Updated the i40e base driver.** > + > + It updated the i40e base driver, which includes supporting new devices IDs. > + > While it's good to see the documentation updates included in with code changes, this is not correct for this set. The documentation update does not belong with the change to "firmware to disable the link on all ports". The documentation update is for the patch, not the last patch, so it needs to go as a separate patch. Therefore this patch needs to be split in two - one patch for the base code change, and a second to update the docs for the base code update as a whole /Bruce