From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0081.outbound.protection.outlook.com [157.56.110.81]) by dpdk.org (Postfix) with ESMTP id 81A8B8E6A for ; Tue, 14 Jun 2016 15:52:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WTQowND+Bk4UWnJF4dCpjQC6SEmDhoPbRGgo6SAPItE=; b=BSdIeQeuvYYP63N1c6Q9a+gHUl1y8l9B6rVN/z4lDcd9F5N4zRlt6ujHsnATwuK5VklxED2djQuOiNVle/oNNtQMZXGTPRW/S79EFmqLbLimrmkS/ayrYrxNDB/nRvDnyPEfDiPAJ5p9nen3U8o2LK7iWQaAWLfeXmvAHC0vNZo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (111.93.218.67) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (TLS) id 15.1.517.8; Tue, 14 Jun 2016 13:52:32 +0000 Date: Tue, 14 Jun 2016 19:22:12 +0530 From: Jerin Jacob To: Bruce Richardson CC: , , , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki Message-ID: <20160614135208.GA2515@localhost.localdomain> References: <1465317632-11471-2-git-send-email-jerin.jacob@caviumnetworks.com> <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> <1465826143-22159-2-git-send-email-jerin.jacob@caviumnetworks.com> <20160613150923.GI15736@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160613150923.GI15736@bricha3-MOBL3> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MAXPR01CA0060.INDPRD01.PROD.OUTLOOK.COM (10.164.146.160) To BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) X-MS-Office365-Filtering-Correlation-Id: a81684ee-792c-4cac-482b-08d3945b23b1 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 2:CYmWdgg2MlQm0vGHxr8aGYFigl+o5iBh95hTs4MXbQwlIFDlqH8lgb5Z2P3ooF0RuSkQTgf/6pGi/0sBqH4clBnmfYWB9yCo+UHGmnh28Qzkjfo27NGlDnsIbQH7vGI1GYcnbLyOdQZ43hPNX0NZAFjb6OoeSR4uQ2Yrf0SkENKOqtPwiRVK6bwy2FvAFXey; 3:f16vzYx8uU4oE+/MbVw4P6hhOlmy91e3rkMePzyKs9iZkrljXqHYx0Xl+YG+LanvYgdvfkG8qjqhb2bIV31J1NWnwHUwXAA124D9g2nwrVpTKfvYLU/vA/ssMT6H2wID X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 25:D/CDbSmseziN+J/cegpr/qVcvx3CUpZoJySra0/gW2oiaPgkysNq0vJrHBX1uvgcjnlaZERGWtYgo96NANzxB/AYP2ATQgKfy1OqPJT4xE1yjU5lh/LMK4gy6vTxVQ2rCQk+T/OziBMPWESLbWcTuCfnifJeNoVjr0eK8cOfInMm8YhpTGv/LicJV6kieUncOd0WyS1l/YwAV5Q9d1ufqphnZ/C4FxMvVd3Y49GuZdbEed9PRQ2ScclyihZajfNSkiBsbUI0q1waKOWq8n9aH1mqIwPLAkhoSTZJM2DIoPVE+KY5tL96MbtBq3jrkoxhWddIEp6C2+UUqxuw0o1/38lFD7KsACmnYYEPmqs2zMdMpAtI7zGMkyZ7BSab4phbSulQcO/6PqQa6KkPQQwzkWCHpWF5DUwBP532IL+bAcUzvJUEStO72YzuAYMRB3dsU2fVYoZvCtH43tAYRVWXSxq5bwJMiSK+YgYVbwDB4mQ2kQMIBnb8P+dtviTV6HgxCKkQwHKFaXjkFWlYId+/XT/mfjTgVLpoGaHc0yTKObdxetfWhwgcDHjwBFLiYJTijtC/tFDRcj3wARwbTC8Akok2/Z01dIe8UVSk39n1bmImQW/jXPTmQWO1+4V+cewuSaXvoMCv4clEeNm42kXV4mecetnD28z/dvpyaTQSQOz3BA9YZ3+GZvvONmvS/sBGGS/gznmP6VVkyGYo1schtTCFJTcYKiqsqIILVCq+jSoYZXrtqBeotxUFEswRNotn X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 20:NM7prQ8/O2EnHWuzrG3/cVs0/zZq7I0eNiEfeAYvH+G8BA6Mlok2hvYcWplJVqDj4GXKR3FyzXuQP5mWqo98g7uNkLCFaLGsNj7IiyMAbgyDUzElVDtg4/UO80BpkOmxhTCOf6UAKxUQMCtwTZNMbKBmhgaTAEMhFc/AsTauyV38tPXbUFPtBHoS4+m8I8r3BCWeHnZjda1LN5O77QJ3ZbeohNLp4RHS57J0t8MZGLYMTjMiLyMZzluSkSX3QL9XT53TX3lIL+PzovBsKMeeXyMBuHT+Fi82s3nFIzr1IWmpoe2ly7MrxjUGrZ0FwvHNH1aUU4Yoy0/dxjn27j8VrbN8uyA26LRvjh1LBlrbDgT2+D8WQ6+xvtV5B+Z6NpjzPKLY3eQ1tRvO5FSHBrIn3OvhJpeLEknZtAvn8GtMlxw8yncpvxJxnHnNYH1S32kt4kRQh0wCVaq/WXg6Wyp2Z46Lf1Dp8XayWKVri6z3VCDO9Fxa/Cu23AS9AZ/9EJRbBnlqqO0k27nBTQG7rS0XBrFJUJVN3LMOf0Fvvnynor4A0yNuU4GkvEKdwUgqxRIcVKoQoQahuWcrOc/RkuFuZDve+qjt2WLtj+4pdi99/H0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:9zMqP0913nuXHi1dj3yJzsVKGx2xCeuzdBbDJ89j3lkqYQEBB+bTK9UhPY9PZLdxPAjlN0XdZOBMt4kRrZTFrWFbdcy6mE/jdLxvxU6KEDf4V+tS2z8p/gjEZMLV/u78edPo+AIbx9wPmLxgfL0inmg/q1dnwbVNn5w7Rs+253NS7GtjCw1SOGxKHMKend9Z4KUGLx0Yf7HNxGCkRPiAnZLJse2HvIKqxywvAVF6d/Hj98GthkgAt8F4GdxqzCo9QHPxOLWTkjkRlFRrUzUl00sCsx6ZnbrsR0SJ7fx9iSxozMLOmsysou/jxNjaHovPaU+g0/FA4Sg1aTxF5JSdBspmsiVWZsH0zifWiMxO91zDEqValQ59fF3BnwogjERy X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(24454002)(199003)(189002)(47776003)(42186005)(4326007)(50466002)(66066001)(97756001)(2906002)(106356001)(105586002)(586003)(23726003)(3846002)(1076002)(6116002)(83506001)(61506002)(9686002)(5004730100002)(77096005)(76176999)(54356999)(2950100001)(189998001)(33656002)(93886004)(101416001)(5008740100001)(92566002)(81166006)(81156014)(8676002)(50986999)(46406003)(97736004)(5009440100003)(110136002)(68736007)(4001350100001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; CAT:NONE; LANG:en; CAT:NONE; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1713; 23:U2T5w9GmCqkTXdB6DTJEiELTKbKs1kGk/diRkOB?= =?us-ascii?Q?8lcg6dRWhFEWy26SAhI0Re/IwUy8AHqzvUsWc4L4tzKaFtU/nlw3t7GiA2Ty?= =?us-ascii?Q?R1t+0cEFmACd+37vS+GnNuCEkdG0MFrt0XhAh4TTNkSdryUm/2kshkpk+zu0?= =?us-ascii?Q?AMwHthNOmNMbpLdX84UlvYS4aA7HQWq8Ftdor2dE+h4LCRzOuBcR4CLzJyUt?= =?us-ascii?Q?6XILnQZKMhc+vZh37mhVfCy1hclv0e/d45hhsGyKpJWeX3b1BZJPNi03Rep0?= =?us-ascii?Q?5ZkMNRjVgH8b2wNl341HCI9lWsX4SayhDtAJY9gqlbk9T04iHnAevmBv7l4D?= =?us-ascii?Q?0/f5XPsFHshVj1a/Oby5H/Vm4xb9uMtGpVJ4pHqYCzD1i0BU0WUKodLoAvRA?= =?us-ascii?Q?aIo87B08trEGW9wuuDocb3Qzunq/essiXmSupjk5Ei1U3no0Z670bCu+uCwU?= =?us-ascii?Q?HhA2C4W61Bmx4IAuYU6gobVFG1U1frum0Gb0lQdhanT71Chx5qai/ieSO0yR?= =?us-ascii?Q?VC3tqkLgtlZtqqHkUZrpznH7UIRl/OKdWd8xpf28Nl0weruunvSnX4ywf8dX?= =?us-ascii?Q?fnpqisKuLOrg0zhUiLHTwQkjbAgOIw87+E3XWtmqFUtVtFFZG5pGniicnYU9?= =?us-ascii?Q?3NdeUiUods3JZIu/OsVzNZpbzMC9j/olWM/vRH36a/V6ZSP2xUJk+XSkMGK8?= =?us-ascii?Q?L8w4pQ2GC2Taw7m3urf6aEN2Jh7t/ZxM7JXgrMgz4dneAwKPRt23HRt8o38N?= =?us-ascii?Q?vYKAZpNDbkmeTWm2jBRaEkVc5mfIe/zbTZIRF48ltV9sdLzidDFzVjE/C692?= =?us-ascii?Q?WDqfpsd0r1/fpKkWmR3EEvGB2BNzPuHLJVvMvc7J0AJG3UIJLjY32ICZPt2M?= =?us-ascii?Q?yN7Jpa+fjVzONL++xfX06DFy+dKe9/SSKI2LaIDI58ue7+LHWfZpWhlGt1qf?= =?us-ascii?Q?BPXwMCKclFpHbHfw1pWrzZE7cIKLrtVBkn/h+mJt5xa7lMaydSH9LBFND+q+?= =?us-ascii?Q?WRQPyIAyCsnu71LifQnJl8wbqEujwetFiB+DZj2GUsxCjBTtmgjqXnuvR2ze?= =?us-ascii?Q?V4W9YBL8EVrQf7lhmynJ2ZF4n7foQhZ9bYUmqxQcHU9Pr0moVFvof/1+hCLQ?= =?us-ascii?Q?cJmxKBPEB77OYej6G6nRN04g/4BGEpRh6uK9JgVkHpMOO5ukZtQ7Y7w=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 6:x+bDFaslih8s8njtZbfVcK+Cq5ZmoVQEmONv6JtvWSquNBrxyHTOD3PVA/A8Wn8iwERnuJ0OSeKmiO7XAFtNmvjAuxjsnHZMbi18us8gRL9ijyY/ifXNNPq0zc30ezY1PxMdOiOg6LLANLN2VBLZw7vitACXHg1KUJIkeQHKa6yLcwXyFZmzzhuxkRxqizD60nf1Zsda0XNYuPZhs3AUX5tyJscKBSXEvjzz+hvBtVC0IqnYsk4BxIZH5gGofz2apEu6SG8ImwBUU3TW8apUFw==; 5:MwQqBwesp405C9PI+WwxYGy7SaYWp7QqMW+FVpGDK1IwTJQiqAS6wjG0OGFk0u0ALdQVO6TqeeLv8ZOi51Pc4Gvv3D/dkA4DBnRBJGt0SLtCR4wQISW0O8Uo6jep6FZ0/gdsBvnHOcPMGVCea/bd8Q==; 24:Epy85mwos3s93/LOS3ua4XxOlF+IuYSuXfpu6BLa0mpsAmHICnvnFyGoPZj8O8p7p3QNKQGYyoxFSUa63fzOklEiPRAsa+L2dfMOuMBxMWI=; 7:1hcqlcZOeB6/h13Ei7b5NmrKZ6ZGLf66pXjQUOAcZTDSolwxFFsQNCJMRwMXcNRvegurKmk1N190uq5OjDfvOJGmvUChveO7+CxrTBhOcZOC19AWof3xwUoHFr/yKGC5cyQxNtIYtE5OuXTqi7ncKnmvtQSMcmBkuPYhTeJXZKv4tf9uqgwCwemsiOhy1iWV1lOeXptOo0FwwI/wH2LW/w== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 13:52:32.1438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Subject: Re: [dpdk-dev] [PATCH v4 01/19] net/thunderx/base: add hardware API for ThunderX nicvf inbuilt NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 13:52:37 -0000 On Mon, Jun 13, 2016 at 04:09:24PM +0100, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 07:25:25PM +0530, Jerin Jacob wrote: > > Adds hardware specific API for ThunderX nicvf inbuilt NIC device under > > drivers/net/thunderx/nicvf/base directory. > > > > Hi Jerin, > > we are trying to move away from huge drops of shared code in a single patchfile, > so as to make the commits smaller and then easier to review. Can you split this > patch into e.g. 3+ smaller commits based around logical functionality. For > example, the base code mailbox functionality in the mbox.[ch] files could be > its own commit. Obviously, the finer-grained the breakdown the better :-), but > I'd rather not see patches >1 kloc looking to be merged in. Hi Bruce, I will send the next revision with splitting drivers/net/thunderx/nicvf/base Jerin > > Regards, > /Bruce