From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Huawei Xie <huawei.xie@intel.com>
Cc: dev@dpdk.org, yuanhan.liu@intel.com, jianfeng.tan@intel.com,
mukawa@igel.co.jp, kevin.traynor@intel.com,
haifeng.lin@huawei.com
Subject: Re: [dpdk-dev] [PATCH] vhost: remove internal lockless enqueue
Date: Tue, 14 Jun 2016 22:07:34 +0800 [thread overview]
Message-ID: <20160614140734.GC10038@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1465818732-116302-1-git-send-email-huawei.xie@intel.com>
Firstly, it's V2. So, don't forget to add version number and link it to
the previous version next time.
On Mon, Jun 13, 2016 at 07:52:12PM +0800, Huawei Xie wrote:
> All other DPDK PMDs doesn't support concurrent receiving or sending
> packets to the same queue. The upper application should deal with
> this, normally through queue and core bindings.
>
> Due to historical reason, vhost internally supports concurrent lockless
> enqueuing packets to the same virtio queue through costly cmpset operation.
> This patch removes this internal lockless implementation and should improve
> performance a bit.
>
> Luckily DPDK OVS doesn't rely on this behavior.
>
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
Applied to dpdk-next-virtio, with the rebase on top of my vhost ABI/API
changes.
FYI, I also renamed the title a bit to "remove concurrent enqueue" as
Thomas mentioned in the last version, that it's confusing to say "remove
lockless" here, since we are actually removing the lock.
Thanks.
--yliu
prev parent reply other threads:[~2016-06-14 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 11:52 Huawei Xie
2016-06-14 14:07 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614140734.GC10038@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=haifeng.lin@huawei.com \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=kevin.traynor@intel.com \
--cc=mukawa@igel.co.jp \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).