From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F030A9AAD for ; Tue, 14 Jun 2016 18:53:43 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 14 Jun 2016 09:53:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,471,1459839600"; d="scan'208";a="987327563" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.8.8]) by fmsmga001.fm.intel.com with SMTP; 14 Jun 2016 09:53:40 -0700 Received: by (sSMTP sendmail emulation); Tue, 14 Jun 2016 17:53:39 +0025 Date: Tue, 14 Jun 2016 17:53:39 +0100 From: Bruce Richardson To: Wenzhuo Lu Cc: dev@dpdk.org, jingjing.wu@intel.com Message-ID: <20160614165338.GA9836@bricha3-MOBL3> References: <1464069991-31051-1-git-send-email-wenzhuo.lu@intel.com> <1464745989-28280-1-git-send-email-wenzhuo.lu@intel.com> <1464745989-28280-2-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464745989-28280-2-git-send-email-wenzhuo.lu@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 1/2] ixgbe: VF supports mailbox interruption for PF link up/down X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 16:53:44 -0000 On Wed, Jun 01, 2016 at 09:53:08AM +0800, Wenzhuo Lu wrote: > In this scenario, kernel PF + DPDK VF, when PF finds the link > state changes, up -> down or down -> up, it will send a > message to VF by mailbox. This link state change may be > triggered by PHY disconnection/reconnection, configuration > like *ifconfig down/up* or interface parameter, like MTU, > change. > This patch enables the support of the mailbox interruption, > so VF can receive the message of link up/down. > After VF receives this message, VF port need to be reset to > recover. So the handler of this message registers a reset > callback to let APP reset the VF port. > Hi Wenzhuo, I'm a little unclear as to the last paragraph of this message. Does the app configure the callback to handle the reset, or does the driver set up a callback automatically and handle the event itself? [In other words, who/what is the "handler" in the final sentence, the driver or the app?] Thanks, /Bruce