From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3495FC486 for <dev@dpdk.org>; Wed, 15 Jun 2016 11:43:23 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 15 Jun 2016 02:43:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,475,1459839600"; d="scan'208";a="976071507" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.81]) by orsmga001.jf.intel.com with SMTP; 15 Jun 2016 02:43:20 -0700 Received: by (sSMTP sendmail emulation); Wed, 15 Jun 2016 10:43:19 +0025 Date: Wed, 15 Jun 2016 10:43:19 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: "Mcnamara, John" <john.mcnamara@intel.com>, "Pattan, Reshma" <reshma.pattan@intel.com>, dev@dpdk.org Message-ID: <20160615094318.GA10172@bricha3-MOBL3> References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <3000552.2jYBPTLpa9@xps13> <B27915DBBA3421428155699D51E4CFE202581789@IRSMSX103.ger.corp.intel.com> <10727658.5TGes6emps@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10727658.5TGes6emps@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 15 Jun 2016 09:43:23 -0000 On Wed, Jun 15, 2016 at 11:32:39AM +0200, Thomas Monjalon wrote: > 2016-06-15 09:05, Mcnamara, John: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > 2016-06-14 10:38, Reshma Pattan: > > > > The new librte_pdump library is added for packet capturing support. > > > > > > > > > > And more importantly, we need a doc in the prog guide. > > > > > > > Hi Thomas, > > > > The Programmers Guide update is in another part of the patchset. Can we get some clarification on the requirements for documentation within patchset? > > > > Should all documentation related to a feature be in the patch for the feature? From your recent comments on patches it looks like that is the way you prefer it. That is fine but there is some confusion because it seems that wasn't always a requirement in the past so it would be best to clarify, and preferably document this. > > When reading a patch (including after integration in the git tree), > it is easier to understand when having the related doc with the code changes. > > > Also, it makes it a bit harder for the documentation maintainer (me in this case) to see doc changes within patches and to ack just the doc part. From a documentation maintainer point of view it would be best to have any, non-trivial, doc changes in a separate patch. > > I understand your concern. > But you cannot assume every doc changes will be properly highlighted in > the headline. I think you need to filter patches based on a content pattern: > +++ b/doc/guides/ My 2c on this is that I think that non-trivial doc changes should be in separate patches and reviewed separately. I think that changes to add a new feature to the release notes, or to add a new tick-mark in the NIC feature matrix should be part of the patches adding the new features. However, a multi-paragraph doc addition I think is better as a separate doc patch. /Bruce