From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 29A08C730 for ; Wed, 15 Jun 2016 16:39:30 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 15 Jun 2016 07:39:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,476,1459839600"; d="scan'208";a="988032644" Received: from fjafari-mobl2.ger.corp.intel.com ([10.252.16.213]) by fmsmga001.fm.intel.com with SMTP; 15 Jun 2016 07:39:26 -0700 Received: by (sSMTP sendmail emulation); Wed, 15 Jun 2016 15:39:26 +0025 Date: Wed, 15 Jun 2016 15:39:25 +0100 From: Bruce Richardson To: Jerin Jacob Cc: dev@dpdk.org, thomas.monjalon@6wind.com, ferruh.yigit@intel.com Message-ID: <20160615143925.GD11536@bricha3-MOBL3> References: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 00/25] DPDK PMD for ThunderX NIC device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 14:39:30 -0000 On Wed, Jun 15, 2016 at 12:36:15AM +0530, Jerin Jacob wrote: > This patch set provides the initial version of DPDK PMD for the > built-in NIC device in Cavium ThunderX SoC family. > > Implemented features and ThunderX nicvf PMD documentation added > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > respectively in this patch set. > > These patches are checked using checkpatch.sh with following > additional ignore option: > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > CAMELCASE - To accommodate PRIx64 > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > > This patch set is based on DPDK 16.07-RC1 > and tested with git HEAD change-set > ca173a909538a2f1082cd0dcb4d778a97dab69c3 along with > following depended patch > > http://dpdk.org/dev/patchwork/patch/11826/ > ethdev: add tunnel and port RSS offload types > Hi Jerin, hopefully a final set of comments before merge on this set, as it's looking very good now. * Two patches look like they need to be split, as they are combining multiple functions into one patch. They are: [dpdk-dev,v5,16/25] net/thunderx: add MTU set and promiscuous enable support [dpdk-dev,v5,20/25] net/thunderx: implement supported ptype get and Rx queue count For the other patches which add multiple functions, the functions seem to be logically related so I don't think there is a problem * check-git-logs.sh is warning about a few of the commit messages being too long. Splitting patch 20 should fix one of those, but there are a few remaining. A number of titles refer to ThunderX in the message, but this is probably unnecessary, as the prefix already contains "net/thunderx" in it. Regards, /Bruce PS: Please also baseline patches on dpdk-next-net/rel_16_07 tree. They currently apply fine to that tree so there is no problem, but just in case later commits break things, that is the tree that net patches should be based on.