From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0096.outbound.protection.outlook.com [65.55.169.96]) by dpdk.org (Postfix) with ESMTP id C247DC49E for ; Thu, 16 Jun 2016 11:31:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=F2tQs2AeJx4qLK22QD4hCISf2SCwmoIV4W548koq8R8=; b=E8MC+g/YjcJOllCa0TDklV9S9ztmvT/KzixLbNmgI/o6MsvvhHk/P4tfalqbQUj4AozDpNnlzphphuJrdRJu8LndOvDGdl2hrDfF4QDeCWFkSj9LR+ULpbpRPfJjCNieylglXzlAUsiUgWWpNTgHAWG4ijb9sMiiLJG/NPAiHkA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.152.114) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (TLS) id 15.1.517.8; Thu, 16 Jun 2016 09:31:24 +0000 Date: Thu, 16 Jun 2016 15:01:02 +0530 From: Jerin Jacob To: Bruce Richardson CC: , , Message-ID: <20160616093059.GA21920@localhost.localdomain> References: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com> <20160615143925.GD11536@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160615143925.GD11536@bricha3-MOBL3> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.171.152.114] X-ClientProxiedBy: BM1PR01CA0012.INDPRD01.PROD.OUTLOOK.COM (10.163.198.147) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-MS-Office365-Filtering-Correlation-Id: c7faf4b3-2dfd-43f8-5717-08d395c8fd51 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:BB9Q38odm2b7YkcWBiyRgtfHaygQaMuEucXkyuOm3Kc2bvgLkN4RsOC3Wl7o1dHeZAaLXS0gcn1/3lJdlx/QJHucSUp/9hr2H9cnPLAR2dZWLldQq2CeJFXnOROL5n5qabr7EKEgPmR2a+t53MUBL+fJPUQyqE1x0G3vs56JxADdr20d757CZDRrygyTcLAE; 3:VsDMoabq/aMrPvUBRMoiQDQna7oyw9fHWh01WFv2Ei8HZg9ZFeT190NEkrhw7ZOzDYlA8Me0+GWrpviciBJOuxkE2cAx38Z0/bIbVYrAF0icN9dfFKH+ARb73E8lgKCT; 25:cdZiDvJRDx0EyMUqL97HRfSoPmHFTPFZ5zKe5THoc14E3xbRd5ZDIvGWnKtIMJaOJ1Gll+qH/0gtRW6nU1ITw+0ej8dZHbGGX4b0JS0B613iplN/RAumEnQaPe7JSth1MljYIxMm1m4WsPr624iWj+DW3ErbedFv4vQojdwMZXwmCY5zXZ8SBYod8Z+4m0yA/Z/uUUWcIr/wTBIbLKIR+RD/SdhIpLUYldVec3Y343wMyVqlmekPB9fvJV7F2XB3IKaL6+v1fIJAat1hxTYpjop0o2Wllr0WR7c79gZ1ileaYkSmxmaIj+flNHvNwJOip1DDodgvuiMiLLxSV8TTlCCyB1EN/h3ApRTRSa+A58vBaHS4otmTK6lrS8zwzGkEjExCtu4tMXc3jlfl69Upttaov8hxg1/w1+7hN76wHSo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 20:vjET3Sr8FzPV61DJkFI47kaCFq4EyW+BjK1nMGz3ZPWTUGV90VOv5zYHqpzUN/kiA7GO5yfhHxJc2hs+vTaDMw/+04gS7WcZhvP+jQDsfHKGzEaidVvtxkbM/q7ZIHJ16/uNWykoK39DJ8wqp79mk6SZ9KAPyge8v/9kcV/D2UE7okKgdSWKBMhHkgoCmy/5G0dmo2H6qimH/GyzxXekyEIbQ7DFp52eOh0RFQRuOxcXRMZu4FxA2+VWu3NrMciJmDlqvJ/ZNyXDdthIzX5Rd18ZlNiz5SDQWukD3k+dyNE+UX2oAGwiDiwd4cysuFeJI4bWue0PWDfCnJtmF2+XNWnGENgP9piA9eXZ+rAevx7NVxXz+SdRRfBQCWwUmGRelS4KvCS/i78BX4LhPXOsmZZb1vmI/K3UZJBDBQJmHFbzuQYEi8ODV347E2t+Y70uFH0dr5NmfDUBvoYZXAzUd1BUSV0nvQf0f7tBO7OdWds/ReoLHW9F2u9ok/Q8nX8zBJ99FJ/uxf3IFsc7CYGOTue5zS8bwDPNSS3/U0iXanVyzHHBmh9n65Q6sKd1/AS3VECjLYbYF244Wn4CGEdfbh5U579mAllOQulAFodcydk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:Ljkpi2JxAgOqA+wyi/XoFZJqpA3xpzB35n04lpo1Y3od4ikbSZndqKykMs+ddfbYZqNONbi+dKlY5JvUUJArKdlVdKaFomr9J0ovqv8lSTYaRht+H+MA6QwGyRnEoXqRnCQGG/JAKtZveZSD7kz1EoAwKzbDQRJplQvQLA0K01h5pSfk8CYvv1cagorTpItrJLiV+ujX2JeXiajm3DeJJZ5PpfxFxe5YwNVX3I9b2aED/ObPSUpu+bcTHxNm2RxXL81Vj/KlZOfuCzvXn15O61uqVs096V+Qo1TshneTmXv7yGafxgUmV3PPlsghIzo1k1KsBCfQwwddKzHiDnLF98ozkT9bnVlkyOVYSQD5iHK4w+Ba+2aKwb9J8TbAqQG3 X-Forefront-PRVS: 09752BC779 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(189002)(199003)(24454002)(101416001)(50466002)(2950100001)(61506002)(81156014)(189998001)(1076002)(81166006)(8676002)(97756001)(4326007)(5004730100002)(2906002)(15975445007)(5008740100001)(77096005)(68736007)(33656002)(97736004)(3846002)(46406003)(4001350100001)(19580395003)(47776003)(23726003)(50986999)(76176999)(54356999)(42186005)(106356001)(83506001)(15395725005)(105586002)(9686002)(586003)(575784001)(6116002)(92566002)(110136002)(66066001)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; CAT:NONE; LANG:en; CAT:NONE; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:2OHRZ39BhwLGuOxOT9xjlilOLFmKytlI82WUk3U?= =?us-ascii?Q?ET1w6DqqCPpi3PCq0+xNOxD1JDLo2Tmzv2GunBB0arikXxx+dir8VBHVddXs?= =?us-ascii?Q?zQXWCr3e7Rjb04DXozwsIVAbf8v1CCT/oCED9fZVFzmEB/7GPszSWmTUKALQ?= =?us-ascii?Q?7pXX+j3jSP2UQMwLdAQZFxjzTW4YPmVLfzS0KtJ3hYdGGudBqbbVEdpuprh5?= =?us-ascii?Q?Nt/RgYjJpbn5mvXPqgYAW59Fer07/k4PYY5xRj505cCnmaNgmh78ODARBfQC?= =?us-ascii?Q?t7AFREzMedX+h8AzWz4USEUIMnR6HY2IHqZ0+wbcdBFwQJOsV90qNQ8qtOee?= =?us-ascii?Q?ladYZhmL8G00dc6UiO/WSzIyfN4nirrTgzwMjN42wzoHwQ8LYhrpCtyVGP6z?= =?us-ascii?Q?tm5d9M/U8kjqrWvx6CAPfzr7TYV9cqR4DQMFBQldO/3l70vKBEZtmMwvpyCA?= =?us-ascii?Q?iFrthzYhMMb/4/8VUkO5bb4RAdQTpxWozSuBy/Bo5sP6Jdd6hiMig1zowpIf?= =?us-ascii?Q?W5u/WCqd0a5riOlrSwvUk6WMupNoYz/6JPRc0HDO/ZEY4of/lVGI0VE1VaOT?= =?us-ascii?Q?R5Kvdq7eWEKYho6v8uUYN3fKhfJJ5s5mbZpJHDZeWfTUPcE0aEJLbq+HGip1?= =?us-ascii?Q?TNNx8dfn6IhvEj9NVPtZe1la+6lo5qDPKKO69XCjlYCpS3lPNc0xPU8S7w65?= =?us-ascii?Q?SodptJ+iVhnA74a5WUEoHJfXBvIABJ0y1uITPXUsOoJhXzOFHPz9IhdQP1/D?= =?us-ascii?Q?uwWi0k3EWzK01cvn4Ix5mKkEPzenX82x5Zn9JKgojV2TBL2g396uaj+Rbg6x?= =?us-ascii?Q?Q3Iq6Up0KdKDUsi/18Ms5chLda41Qbm/0qI8RLZWJEZe/J2Ig3lN347m3Foa?= =?us-ascii?Q?348SlQ5ht9sXJqeBcl5BoljikDbD/1l6lbE1C8IFP0FFBkQjkHmWlFd0fhSX?= =?us-ascii?Q?U0RQ/lokExzNTk0KbYI4H4j2SM7V0kgdlN8BoMBENVkJzJeGg7epfCdz7HZY?= =?us-ascii?Q?cZrQXfgi5ywZNUpEBGo1K/m6x927XLyT3NaCUPiOllNXljy0aAHxeDxXY2tt?= =?us-ascii?Q?/8aHDolWWUsu3dgvtqxiUyRMwChpFOF5LfJMv3fKrnTNdKoPyr4aXPLrGSbi?= =?us-ascii?Q?5Kui0nhpUpRGdDq8gWuu2VT9QC7E8vEjz5DkSCC0kNT98dK7aUjnoDYWO6Yz?= =?us-ascii?Q?xZ1Fs2xr1tm0kwKONIq5nyoIgzgrNdk4UoQ46L1ed4AUkYSm/NYoSXQeflw?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 6:UN+e8J6drscLRvX9rW69NhW1lzvVJNEBia/OHuwrzJ4GlHUhCRTM/KKzCNjTxbm92VZdbm2RPnvawv1ppSDrq5i54C19jE18S3wTKfHXMZWYjITob+1zhxuqi0q9mb3mkZS5YIs5utaPpaIA0Vp8DtsvfG6CCogxEN6bjyOFoWiVKgj1tqmWwkWEdyzV/DNCPQekaCIEjBa0Bx49+jATyet6pYr2YKwmBEvX8q5c3dXZHYGxyUMBsTZTNJuz3KZgvrceBdzH0+iWaimPPB6y1Djzp+VCkeICmRofj/5AwV0=; 5:DrA/BAg83m+yvDJvomYJmaNLysdaDUz43aYPo4AXgutt1Q5zY9X2Aokbncrk1pF25enY0HDYpSmkSXeCwtM/c6yXdu1gVbbK1fgOfn7TnLKVXs5x8lGAt2yTxdvQ5KBIFJhTwJOsV16BncxHVLmSgg==; 24:pbTLq7ojwuCRfuziMEBTqUbOjIR+lnmfpPwsu14RVxcliNuFFCkVuRKMNRHmgw02NXz6m1Q3EuP9PUtjWRLeo3XeRa5VnlzXX+21pCTcBy4=; 7:ZuoI/ryBxcbpxfoR+32KSrtD7FB8Ljmi9ZeMyCgyEPzPkUKnp3ATMK0OrqseWjq8Arym6o3RNRxCIUrgawrhrg82XTJga9MVl5CQy11RhTSEVDpSRnVxy9LZWel/N6kPLYT4LjR5Hlgk/BpKGVU3GWLB6kKiJc1Jz7uti/mFuTJ6fQ26aHYDDBlrr19gJL6FdbiPVZrtKMim06O4KQr5SQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 09:31:24.4397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH v5 00/25] DPDK PMD for ThunderX NIC device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 09:31:28 -0000 On Wed, Jun 15, 2016 at 03:39:25PM +0100, Bruce Richardson wrote: > On Wed, Jun 15, 2016 at 12:36:15AM +0530, Jerin Jacob wrote: > > This patch set provides the initial version of DPDK PMD for the > > built-in NIC device in Cavium ThunderX SoC family. > > > > Implemented features and ThunderX nicvf PMD documentation added > > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > > respectively in this patch set. > > > > These patches are checked using checkpatch.sh with following > > additional ignore option: > > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > > CAMELCASE - To accommodate PRIx64 > > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > > > > This patch set is based on DPDK 16.07-RC1 > > and tested with git HEAD change-set > > ca173a909538a2f1082cd0dcb4d778a97dab69c3 along with > > following depended patch > > > > http://dpdk.org/dev/patchwork/patch/11826/ > > ethdev: add tunnel and port RSS offload types > > > Hi Jerin, > > hopefully a final set of comments before merge on this set, as it's looking > very good now. > > * Two patches look like they need to be split, as they are combining multiple > functions into one patch. They are: > [dpdk-dev,v5,16/25] net/thunderx: add MTU set and promiscuous enable support > [dpdk-dev,v5,20/25] net/thunderx: implement supported ptype get and Rx queue count > For the other patches which add multiple functions, the functions seem to be > logically related so I don't think there is a problem > > * check-git-logs.sh is warning about a few of the commit messages being too long. > Splitting patch 20 should fix one of those, but there are a few remaining. > A number of titles refer to ThunderX in the message, but this is probably > unnecessary, as the prefix already contains "net/thunderx" in it. OK. I will send the next revision. > > Regards, > /Bruce > > PS: Please also baseline patches on dpdk-next-net/rel_16_07 tree. They currently > apply fine to that tree so there is no problem, but just in case later commits > break things, that is the tree that net patches should be based on.