From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0077.outbound.protection.outlook.com [157.56.111.77]) by dpdk.org (Postfix) with ESMTP id E6385CC1E for ; Fri, 17 Jun 2016 11:43:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=U3jvmUD1w7oXYGROPHHyd0U4s1J2DtqIhxkGWtAPPKU=; b=d0fAm0bxK1EFGg3ILcrJcbRhmW74XHDJMYvvj55xkARsr/Z6ymsT+wDj9e/g0lb95Mkzr7EraQ5YUUYN30/8u7rUv2tPjsTHPaPa7ubDTtA5EamV/A3/Cv6TgjVLprh6A+AerBYJ7cYb+HfXrPa5uLBwniFdbdV8+xWA+VtMNoM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (111.93.218.67) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (TLS) id 15.1.517.8; Fri, 17 Jun 2016 09:43:07 +0000 Date: Fri, 17 Jun 2016 15:12:42 +0530 From: Jerin Jacob To: Thomas Monjalon CC: "Jain, Deepak K" , , "Griffin, John" , "De Lara Guarch, Pablo" , "Doherty, Declan" Message-ID: <20160617094241.GA32149@localhost.localdomain> References: <1466090950-12231-1-git-send-email-deepak.k.jain@intel.com> <11386705.985BuDGx4F@xps13> <7138878.rfgI980QT2@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7138878.rfgI980QT2@xps13> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0063.INDPRD01.PROD.OUTLOOK.COM (10.164.136.163) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-MS-Office365-Filtering-Correlation-Id: b047f66d-36d6-4c6b-fdcc-08d39693cb14 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:vI/zjGzbGtkJN7nS5/LXJSP6ci3RgD31EbXVcPKwyN5rmEvFv+UqO7tvYhnmKxZhGDyeBnAbH41lUodMm9frLPRk+FjnM7HsqnG8DFdO/4eqPYPhpSlpKboDC43eFhzqpl5KMZ8pdcU/qYTOsyGslGW5/tibGDtc++ZRjV5+csgMMO0fAL2mS1337plxSyca; 3:IzSqmCuiTLXQh9Od8u0YIyDiekgllOToz3dK5UKc2WRNZURtaCl+AGiPNLPmLyr4bXw9m1ULviqK1d3ksHe+FoB/5P58YrShNvX0aSC8wrcxGKBhYqxdx1wdODB/tSKL; 25:NHGsVl/+KQAEtXkg+rkixY+1DG4HksXmRqmm1JUc4vrII0rSqBHKN0XOFnfpMBvMQblr+EN7mp9/Q736OTT3J3quo5yO/L03Lk8Fe0n1JLD9AJAXXxqO8UT2AV2auTAXwB9qiRAZcmIUNLqNv8/pHLZBqtxNs0vyVaznztsrXzmLkoJ6dtwNlymx/0wG1IHMh+9OzyTezTiqqymi/o68Al5aQMK+QYSFbcwgkL6h7IzJ3Nv0NPTTRjUqKuwtF7kB3aSeC56NUTolTDd1EvxBfRp557DIadzEyaCCKzWtn4mLbgVt32YaqhbQTfRfqUthgay21wvZbb+wsqoTX3pg+KaBwkysSPwYBH9t731LLt6zOaM3Yf9q2vtJPAWkFZkyKsDpO4KbyCibhYfUgEAalaMEzek9Utv9ErzoTU9QRuA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 20:3Te3RXYTZ6A1jw9Rz1jKwZYrGhsuqAg1zglOwSYjXlmvOL32LWX6iP6DwZKtGQSeQcY0ENsDitf/P71pK3q7580wFjXeAHEgEw53qJfAfGnoAzmoCukuxa5hySK4UJu4iKx58mwTQLDhGRztaAdTfKjbACeLqCa965o58gATlcnrhcr2x4BOQO+KUxCRZwyCNrjDiDEN8ShZ2rHbIWUW+AL/UMl+CitmJEea4O9fUc3uTXMWhg/oyYceUx9iX9KPVYQzKlXPXG489RKxUflREiOcYe5PlxVqP5UetdVgemFAJLUDtx2MKL5JsKEfjCLLd4Gfcqd3i7rFKt6To3CqLojQ4J7mFj1zp5P+2+gFL/f5RXfqNDMWcitRtT9OQa4oPH0ZjcuixOhTlQ+XdSbJJkZRp0oBDKl65jJyWrKanhzJptD3YUX4LQEvbeDYrHDJjGlNKi/1vB+rk1ZT6fdKUBAzhSKmDEckThAxDeN5ubwbSM3d9pBdd45BYQLLLvVwiA+g/VsYqhLlTusDfhFuOyi7+TLX/uQ0mMRJiwhYiYnEusI5z/s7lRa/OF6zwa29wn6R7/yPjdRcSRCFAkKSr724PyQIKh7Uc43YmQCSMUM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:8wLnaEaqXyj3gG9HianB289E00bR2t+4uACUpUiOt8hEDQ7lJjvlq+zSYMR+9WFfRYnm8yOZYA/qX2z78nZ01PgDB2+PDArMuZHteG7MG8sQ6gyS7NUpYCYSg8NIa4xr9s5R/hszTgz2ug8+aAtHdeCK9bFx5AI/YjIWU/vfqQIlLC55up5O6JGDhWqI7OfT3WRYDBj7hiJpEoz7z47KBtdWThMOG1zCu/5++fIKuh+LOJKOCoo+E8r+mrjMOd1I9lZBxxN2/sMNIj8J5Z8dpJZyCqx1GYGw6f5hLtbweCWyKjdCZz9qUuSJRNQU3PrDm4CyhxIbubZOyAWIrl+vlWI1zW1ttdIo8/lRejI1sRBtyAAnT5M8si7qOErMpyb+ X-Forefront-PRVS: 09760A0505 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(24454002)(377424004)(199003)(189002)(23726003)(19580405001)(5009440100003)(47776003)(33656002)(42186005)(3846002)(4001350100001)(68736007)(97736004)(586003)(575784001)(6116002)(19580395003)(9686002)(66066001)(92566002)(93886004)(83506001)(54356999)(50986999)(106356001)(76176999)(105586002)(46406003)(61506002)(4326007)(189998001)(81156014)(110136002)(101416001)(2950100001)(50466002)(5008740100001)(77096005)(81166006)(5004730100002)(8676002)(1076002)(2906002)(97756001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; CAT:NONE; LANG:en; CAT:NONE; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:Kv1IpaeezsUxm5TveVoWnw+70JXWTOM445vSqIN?= =?us-ascii?Q?TFJ9ljgAYQCRC4ZWLi5QjMaKdJHu65+4gdTI8NLS1qSxSN5hDQKhdOnlP/Nl?= =?us-ascii?Q?GWTcqJZTUFMbCQHvMUnR8dxW1Ie7QB6xe7qY1m1hViKEfzgFm7QKzEQhVQS6?= =?us-ascii?Q?NVoVuTWq7NQsvFCaInMCtIA3jB9HwfoWGDX3AgCM8xtL+jv5y8Yz3dH/fEl+?= =?us-ascii?Q?80vGlYciUoxFiKVcCNYs/1wcTKNzohxWJ3/Y/rZI9Hqw2bc9EgjN6OrmiCYK?= =?us-ascii?Q?AUIPwMagm/kMSweKNGujaspxiBUiTi/ucgOyiXWfRPX59Nfu51FbYNSFo/EE?= =?us-ascii?Q?vjTnOcyy0MI5ec40uhSzoYVK1NCRGi2lVRWvicga+pWBpgnELBnKCbiRm44i?= =?us-ascii?Q?3EMxqPhxHYxggxAvzvpBwBHwBxC9i9/FmFQtbDNacyBj9PcGX/KYcga5qCWL?= =?us-ascii?Q?nrC8c3ty+fIbyFHIRnr1FAa5sDTlHqRdAZKdsrpiy6PljlotOWO6jSKDC3ro?= =?us-ascii?Q?21Ascm/ov2OB8z2TOnLhEG70NLPaZdYRcrdeDyKrFiAxim/7VEBbMZ5XggbK?= =?us-ascii?Q?UhcaQEh2EtmSm1nRzpal4p3JTJhPNxpb+0OprzUXl6dE5U+o6llorQhRvLBX?= =?us-ascii?Q?5bENq2jBSM2jMQpZv4J9aOhKK9CkfAMiBz+MMljTnoGI8m7f4qGI+aF+N+uo?= =?us-ascii?Q?StaK042rCTZaZmk+qiQaWm1rFH//EEo3wt33zGvgWhB17Qh9xmP4cXdADQH4?= =?us-ascii?Q?oY8zRsNKGRCwBU3BUD6/sAt5hLlK1h34UGEjg8gGgbIvTc2HNnWS3AYy7ag/?= =?us-ascii?Q?8xDyn6ZfFzpV7yFToUj/7kHhFGbYx/RVeK0QAUPtVN2pmR2zOpOs9jR5X5y9?= =?us-ascii?Q?2emOft5Uq7WGpq3bscr2bHVTkE+yPRRn+pr07skBTxj3RxYUHTXhFXYirf2o?= =?us-ascii?Q?i/xO2BHL3xZH3zraT63U6F5n02J/8SC9tL+/5PuVRuMvmd6LGgCnsL1Cd9EC?= =?us-ascii?Q?nKukd/xBLkhJLJGEaYREx5GQLf0uC2hu9yy1m53Q+8jyAU4kStBNTKCPDzK8?= =?us-ascii?Q?A1m+EdzLX2EAU67htOz6A4c3hkIqoTLbUCNS1WGp6cA/LI2kZj7mbBedT0SP?= =?us-ascii?Q?1XgSpIUrJMbIeHj9ODFsmtPT2HQKlOCG4ZxEBxThvnTCN4PqRFmGJYVoAS4l?= =?us-ascii?Q?sy1QzPaOf1zk9Zprjv3OaHGSAFNukiaQMwr+MvXrKZ8YUoRK3Kgpp6mXcZvj?= =?us-ascii?Q?WpkgxXYzbRFVCQ6StxB9h/8iUJbkYliXopz0dG3rD?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 6:DRHFTAXY/N7ogVapKd376E0hSHINojlFQOSsqRBgaetjwNJafzsAYGX4ZhWvjMTB92K09AEUu5a8YWYUBHfNxa0mfe6a5WepwJF1qcAtCx67BBflVHs6HUsCak0yzYuLCnhEE7mgQcITNRtw9nBRjSeTNvsDMhvB7ujKEhJt1GRAXf9bpCVfus3bzu2tuImiqeeZGMegUfRGVMORfr4COk9R06231WhbbakrMrXiWwGv9JHzz0vGxcFkrGdQUtNt8yubcH8V3qg/abejgsw8QMpYZbV3IMfdKIgVC/GrUVw=; 5:FAKtujymLiP9QVoOR+EtZAiqaD+o1puHTOqLg/UctgzSlDfuINlw1P/xMaLbzzVGA7BHKJ+rKswBnyGzZuSO1/YtEmxR5A56vwtagg4MAMid2mmM+pP8GRulE5xKrYSK/4WJM4tnCuxxTXMue0lfkg==; 24:rcUL4rrVaN7umNa/jyATAQT3f+lnW83/pn3hNoqVojLSzjiwJvpPobUMLyMZvC1VpXlnPGehhytmARgbkbwvzdyHzRLDwk3OX9ydqrOODKs=; 7:5WUkkDSQSPDIE1dUqjSFfzDGv/DEGbiB7vaKaCZvy7urTZVH9Zie8jtHqGY0oH1rirT9IwZQWrID398JzoiiRJTr0Bd5jg038dfMYGS3KJh94kYeVPgNGsuggsgS44qNv7jlWSBoMj+dEi8A/jgrBJZO0a0hO9nPdVd6FJHIeqp4Y/woaFvhUoc2YnfLEhwiOcpMyYiFx7EwSFvnyb6baw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2016 09:43:07.2077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH] qat: fix for VFs not getting recognized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 09:43:12 -0000 On Fri, Jun 17, 2016 at 10:18:30AM +0200, Thomas Monjalon wrote: > 2016-06-16 16:25, Jain, Deepak K: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-06-16 16:29, Jain, Deepak K: > > > > Due to addition of CLASS_ID in EAL, class_id is amended into the code. > > > > > > Why the VF is not recognized? > > > The class id should not be mandatory. > > > > Without the change proposed, QuickAssist Devices were not visible and hence tests were not running. > > Seems like changes in EAL especially where class_id is added affected the QuickAssist tests. > > With this change, QuickAssist devices are visible during tests and tests working fine. > > Which tests? > Have you investigated why? Thunderx nicvf also got the same problem when I rebased to dpdk-next-net/rel_16_07. The root cause for this issue is that, PCI CLASS_ID EAL add changeset(701c8d80c820461e8255dfb7387a09f0e54399f0) has taken care only the pci devices where id table is created with RTE_PCI_DEVICE For other devices, class_id comes as 0 instread of RTE_CLASS_ANY_ID and probe failes. To fix it, one option is to add RTE_CLASS_ANY_ID for the devices where pci id table is not created with RTE_PCI_DEVICE or somewhere in common-code in the initaization set if class_id = 0 then make it as RTE_CLASS_ANY_ID(Thats would be a hack). Seems like first option is correct-way to fix the problem? Any thoughts? looks like following devices does not exhibit this issue [dpdk-thunderx] $ grep -r "RTE_PCI_DEVICE" drivers/ drivers/net/szedata2/rte_eth_szedata2.c: drivers/net/bnx2x/bnx2x_ethdev.c drivers/net/vmxnet3/vmxnet3_ethdev.c drivers/net/enic/enic_ethdev.c drivers/net/e1000/em_ethdev.c drivers/net/ena/ena_ethdev.c drivers/net/qede/qede_ethdev.c drivers/net/ixgbe/ixgbe_ethdev.c:#define RTE_PCI_DEV_ID_DECL_IXGBE(vend, drivers/net/virtio/virtio_ethdev.c:#define drivers/net/i40e/i40e_ethdev.c:vend, Jerin