From: Bruce Richardson <bruce.richardson@intel.com>
To: Wang Xiao W <xiao.w.wang@intel.com>
Cc: jing.d.chen@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic
Date: Fri, 17 Jun 2016 11:18:34 +0100 [thread overview]
Message-ID: <20160617101833.GB14948@bricha3-MOBL3> (raw)
In-Reply-To: <1465203647-18717-1-git-send-email-xiao.w.wang@intel.com>
On Mon, Jun 06, 2016 at 05:00:47PM +0800, Wang Xiao W wrote:
> When app tries promisc/allmulti setting, fm10k will check if a valid glort
> is acquired, if not then exit without doing anything. It's a long journey
> for VF to acquire glort info from VF to PF mailbox, PF to switch mailbox.
> It could be a long interval that's out of DPDK's control. Thus, app may
I think the use of "thus" here is wrong, as I suspect that the failure is not
due to the "long interval that's out of DPDK's control", but instead due to
not having a valid glort.
> fail on promisc/allmulti setting in VF. In fact, we don't need a valid
> glort value in VF, so this patch just skips the glort check for VF.
>
> Fixes: df02ba864695 ("fm10k: support promiscuous mode")
>
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
I rework this commit message for you on apply. Please check the updated version
when done.
/Bruce
next prev parent reply other threads:[~2016-06-17 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 9:00 Wang Xiao W
2016-06-14 5:03 ` Chen, Jing D
2016-06-17 10:32 ` Bruce Richardson
2016-06-17 10:18 ` Bruce Richardson [this message]
2016-06-19 13:47 ` Chen, Jing D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617101833.GB14948@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).