From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2D2A4CC76 for ; Fri, 17 Jun 2016 12:18:38 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 17 Jun 2016 03:18:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,483,1459839600"; d="scan'208";a="830024242" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.182]) by orsmga003.jf.intel.com with SMTP; 17 Jun 2016 03:18:36 -0700 Received: by (sSMTP sendmail emulation); Fri, 17 Jun 2016 11:18:34 +0025 Date: Fri, 17 Jun 2016 11:18:34 +0100 From: Bruce Richardson To: Wang Xiao W Cc: jing.d.chen@intel.com, dev@dpdk.org Message-ID: <20160617101833.GB14948@bricha3-MOBL3> References: <1465203647-18717-1-git-send-email-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465203647-18717-1-git-send-email-xiao.w.wang@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 10:18:38 -0000 On Mon, Jun 06, 2016 at 05:00:47PM +0800, Wang Xiao W wrote: > When app tries promisc/allmulti setting, fm10k will check if a valid glort > is acquired, if not then exit without doing anything. It's a long journey > for VF to acquire glort info from VF to PF mailbox, PF to switch mailbox. > It could be a long interval that's out of DPDK's control. Thus, app may I think the use of "thus" here is wrong, as I suspect that the failure is not due to the "long interval that's out of DPDK's control", but instead due to not having a valid glort. > fail on promisc/allmulti setting in VF. In fact, we don't need a valid > glort value in VF, so this patch just skips the glort check for VF. > > Fixes: df02ba864695 ("fm10k: support promiscuous mode") > > Signed-off-by: Wang Xiao W I rework this commit message for you on apply. Please check the updated version when done. /Bruce