From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 7861F9616 for ; Mon, 20 Jun 2016 11:25:24 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id r201so52551072wme.1 for ; Mon, 20 Jun 2016 02:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=qMDvbL+7+LD3PTArFjMvCw+FTEhYbWXpcByNyuIs34Y=; b=G0T5GmVLaB9SZcMYl5zGzVmsj8dzAlY3Z0FKDHp6NmmdRGku3SouqO2Ml2mQbQeYe/ XPnuQk5Z4BERGxNhumu0z0lvF2StRWjbEf+GnKIWNwWBmtR9ADlUDBbJEnZSh8L1a5BI kRarZcVzkWBdxRzAp21b/m41v4vXRfBtv9QNuEIkExR+jb4BD7RXmlKPCp9n4thpWuSp I3lURZFGS6M3STt9v++bauHn+96rPlewZP4dNbtj7aFKVs/aBKCumBM4YzckfQLIs8OM JDzA8ub4nmkYcrP76Cq0bpGOl3+95WdVXpgpO76+gAY38udFH1pSPDlc6v8Ia8ZbU/6Y 08Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=qMDvbL+7+LD3PTArFjMvCw+FTEhYbWXpcByNyuIs34Y=; b=gle7k6DO9LA4roEsz9+MUhbzp9nWTsQZyzLDmDyKkj4luKCNJ+736TpsXCnISRJzdl JdP/FZjtwWcj26vPmZRmZtGpFQE//ODfGmOqtEZdzjp1m9/npCYEQz6drCedgZQ4IcRJ nECDMkYcxM5tI+25buKIJSqcxropngm7u1zmhkI2wSMQZlijOD3ONkhEx+bWcha0H9vM IQXCwaNhuz65CQt3pPNFSiJNxQc2RLBH9j52nsVD0dM/nvMQNy0cLO0by/MD+E6kGAly cC/kReQAuvRNiQfD7w56hJIonGxus7/oMa1QNgTrh6mx2qcmWO5MOtwtw4KLlxx2yLG1 M8+A== X-Gm-Message-State: ALyK8tIPBIISqOuaw9iFjsNy5PPqWCeB3Qv/tVySglT+4iqwBmG063/EoTLZqwNwR1iAejxI X-Received: by 10.28.94.18 with SMTP id s18mr4021669wmb.42.1466414720852; Mon, 20 Jun 2016 02:25:20 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id el4sm29866001wjd.23.2016.06.20.02.25.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2016 02:25:20 -0700 (PDT) Date: Mon, 20 Jun 2016 11:25:18 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Bruce Richardson , dev@dpdk.org Message-ID: <20160620092518.GT7621@6wind.com> Mail-Followup-To: Ferruh Yigit , Bruce Richardson , dev@dpdk.org References: <1465571372-28254-1-git-send-email-adrien.mazarguil@6wind.com> <1465896120-17173-1-git-send-email-adrien.mazarguil@6wind.com> <57642581.8070704@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57642581.8070704@intel.com> Subject: Re: [dpdk-dev] [PATCH] mlx: fix compilation with older Glibc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 09:25:24 -0000 On Fri, Jun 17, 2016 at 05:29:53PM +0100, Ferruh Yigit wrote: > On 6/14/2016 10:22 AM, Adrien Mazarguil wrote: > > A missing define in the previous patch causes additional compilation > > issues. > > > > Fixes: 3025206f5060 ("mlx: fix compilation with recent Glibc") > > > > Signed-off-by: Adrien Mazarguil > > "older Glibc" or "recent Glibc" can be very hard to trace from git > history later. I wasn't sure about the exact version, it appears to be 2.19 and/or 2.20, where _BSD_SOURCE was modified and subsequently removed. I suggest squashing this patch into the original broken commit ("mlx: fix compilation with recent Glibc") if possible, I did not submit a v2 as it is already applied on dpdk-next-net. > Does it make sense to add glibc version info for the failing ones or > fixed one? Depends if we can modify the first commit. If we do, let's squash them together before adding version information, otherwise let's modify the second one only. I can submit a v2 that overrides both commits or only the second one, tell me what you think is best. -- Adrien Mazarguil 6WIND