From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 854AC6CC8 for ; Mon, 20 Jun 2016 12:05:27 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 20 Jun 2016 03:05:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,497,1459839600"; d="scan'208";a="722166283" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.18]) by FMSMGA003.fm.intel.com with SMTP; 20 Jun 2016 03:04:51 -0700 Received: by (sSMTP sendmail emulation); Mon, 20 Jun 2016 11:04:50 +0025 Date: Mon, 20 Jun 2016 11:04:50 +0100 From: Bruce Richardson To: Ferruh Yigit , dev@dpdk.org, adrien.mazarguil@6wind.com Message-ID: <20160620100450.GA19416@bricha3-MOBL3> References: <1465571372-28254-1-git-send-email-adrien.mazarguil@6wind.com> <1465896120-17173-1-git-send-email-adrien.mazarguil@6wind.com> <57642581.8070704@intel.com> <20160620092518.GT7621@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160620092518.GT7621@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] mlx: fix compilation with older Glibc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 10:05:28 -0000 On Mon, Jun 20, 2016 at 11:25:18AM +0200, Adrien Mazarguil wrote: > On Fri, Jun 17, 2016 at 05:29:53PM +0100, Ferruh Yigit wrote: > > On 6/14/2016 10:22 AM, Adrien Mazarguil wrote: > > > A missing define in the previous patch causes additional compilation > > > issues. > > > > > > Fixes: 3025206f5060 ("mlx: fix compilation with recent Glibc") > > > > > > Signed-off-by: Adrien Mazarguil > > > > "older Glibc" or "recent Glibc" can be very hard to trace from git > > history later. > > I wasn't sure about the exact version, it appears to be 2.19 and/or 2.20, > where _BSD_SOURCE was modified and subsequently removed. > > I suggest squashing this patch into the original broken commit ("mlx: fix > compilation with recent Glibc") if possible, I did not submit a v2 as it is > already applied on dpdk-next-net. > > > Does it make sense to add glibc version info for the failing ones or > > fixed one? > > Depends if we can modify the first commit. If we do, let's squash them > together before adding version information, otherwise let's modify the > second one only. > > I can submit a v2 that overrides both commits or only the second one, tell > me what you think is best. > > -- While I don't like squashing or modifying already-applied commits on the next tree, since this is for a compilation issue, I may be able to make an exception. To evaluate it, please send on the proposed updated commit message for the combined commits. I assume the code to be squashed is as in this V1 patch. Regards, /Bruce