* [dpdk-dev] [PATCH] virtio: fix crash on querying xstats
@ 2016-06-20 10:50 Yuanhan Liu
2016-06-20 11:02 ` Remy Horton
0 siblings, 1 reply; 3+ messages in thread
From: Yuanhan Liu @ 2016-06-20 10:50 UTC (permalink / raw)
To: dev; +Cc: huawei.xie, Yuanhan Liu, Remy Horton
Trying to access xstats_names after "if (stats_names == NULL)" is
obviously wrong, which would result to a crash while running "show
port xstats 0" in testpmd with virtio PMD.
The fix is also straightforward: just revese the check.
Fixes: baf91c395b18 ("net/virtio: fetch extended statistics with integer ids")
Cc: Remy Horton <remy.horton@intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 19d5d8a..12fa640 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -776,7 +776,7 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
unsigned nstats = dev->data->nb_tx_queues * VIRTIO_NB_TXQ_XSTATS +
dev->data->nb_rx_queues * VIRTIO_NB_RXQ_XSTATS;
- if (xstats_names == NULL) {
+ if (xstats_names != NULL) {
/* Note: limit checked in rte_eth_xstats_names() */
for (i = 0; i < dev->data->nb_rx_queues; i++) {
--
1.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] virtio: fix crash on querying xstats
2016-06-20 10:50 [dpdk-dev] [PATCH] virtio: fix crash on querying xstats Yuanhan Liu
@ 2016-06-20 11:02 ` Remy Horton
2016-06-20 11:47 ` Yuanhan Liu
0 siblings, 1 reply; 3+ messages in thread
From: Remy Horton @ 2016-06-20 11:02 UTC (permalink / raw)
To: Yuanhan Liu, dev; +Cc: huawei.xie
On 20/06/2016 11:50, Yuanhan Liu wrote:
> Trying to access xstats_names after "if (stats_names == NULL)" is
> obviously wrong, which would result to a crash while running "show
> port xstats 0" in testpmd with virtio PMD.
>
> The fix is also straightforward: just revese the check.
>
> Fixes: baf91c395b18 ("net/virtio: fetch extended statistics with integer ids")
>
> Cc: Remy Horton <remy.horton@intel.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Acked-by: Remy Horton <remy.horton@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] virtio: fix crash on querying xstats
2016-06-20 11:02 ` Remy Horton
@ 2016-06-20 11:47 ` Yuanhan Liu
0 siblings, 0 replies; 3+ messages in thread
From: Yuanhan Liu @ 2016-06-20 11:47 UTC (permalink / raw)
To: Remy Horton; +Cc: dev, huawei.xie
On Mon, Jun 20, 2016 at 12:02:16PM +0100, Remy Horton wrote:
>
> On 20/06/2016 11:50, Yuanhan Liu wrote:
> >Trying to access xstats_names after "if (stats_names == NULL)" is
> >obviously wrong, which would result to a crash while running "show
> >port xstats 0" in testpmd with virtio PMD.
> >
> >The fix is also straightforward: just revese the check.
> >
> >Fixes: baf91c395b18 ("net/virtio: fetch extended statistics with integer ids")
> >
> >Cc: Remy Horton <remy.horton@intel.com>
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Acked-by: Remy Horton <remy.horton@intel.com>
Applied to dpdk-next-virtio.
--yliu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-20 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-20 10:50 [dpdk-dev] [PATCH] virtio: fix crash on querying xstats Yuanhan Liu
2016-06-20 11:02 ` Remy Horton
2016-06-20 11:47 ` Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).