From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 8FE5B95DA for ; Mon, 20 Jun 2016 17:11:30 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id a66so83367828wme.0 for ; Mon, 20 Jun 2016 08:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ot4qi2gVCx2ME70+fjl6Znqe08JX2t3LaFJt8sTJgJw=; b=koeB2rVMwDijwB8i/NPoEqsMN4qVP9kuOK/ErtFxVvalfA77lVyCx+PmeVcNvAYrNQ kJKiRxOiqNJBYkpWUhbt0JPKeqfHAQFegtOQLCozKgkcUjQ/ho+nDD23B0XbJVrTUFb5 cFeK7Xpc2Fn0PnSlp5JL9+dYzxY0Y31UBkKCVNdNkZoxnqmnWl/pBjBADlXY1luq/ymv q3wlARJk8dqyGLe2+3MNt88Pxry47nkK8Mnhkh5idJzdREnRnQxVS8lB7OjwjBmo+Bjw 576FDd9JUDzbKpP76MDkStbKJOP2UkP/7ynj3VFG+/fyp1iT0iDBIGUrw/MgmI0dOsyW QUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ot4qi2gVCx2ME70+fjl6Znqe08JX2t3LaFJt8sTJgJw=; b=mIWL/iOdafO8WZB3QO1+4zG4sCBmQrqe5v4BoEcdcTv1uvQrqGHhpIYnX55bGK/4FO fVFEXkqGcu/xJZL+EHItKt4P5inZBd8hfoaqR8JTcfc/1zMyTvwK2+IUFKytlCUzMisP VgtqyRCo9U5f82ZDQUKoCQMgkVge28OpVp913AMPiBm7L2FQblOyvV5S51d3FDLJQvIT epr36qckKeygUbtVwrwTJiLIRXxna5TlcX99rxHmiY6Q+q/ZWxz+a9pJ8SaWDL1Jw/jL Y5xl7QKoGE1nVnkaRIOIeeHaiTc3wcpzJitYvORfeWMQKvScL/0bwPicqbY62te2ecle yV5w== X-Gm-Message-State: ALyK8tJEnayI/Tf4FBuQWibKiSkYsODNYT6Z55yN72/ksrnSuzTYHWyVkn5c1x7LAshB2ZVJ X-Received: by 10.194.15.69 with SMTP id v5mr7609981wjc.108.1466435489981; Mon, 20 Jun 2016 08:11:29 -0700 (PDT) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id i14sm5923072wmg.7.2016.06.20.08.11.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 08:11:29 -0700 (PDT) Date: Mon, 20 Jun 2016 17:11:28 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20160620151128.GJ14221@autoinstall.dev.6wind.com> References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> <576420C7.6010301@intel.com> <20160620073854.GE14221@autoinstall.dev.6wind.com> <576805A4.1030204@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <576805A4.1030204@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 00/24] Refactor mlx5 to improve performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 15:11:30 -0000 On Mon, Jun 20, 2016 at 04:03:00PM +0100, Ferruh Yigit wrote: > On 6/20/2016 8:38 AM, Nélio Laranjeiro wrote: > > On Fri, Jun 17, 2016 at 05:09:43PM +0100, Ferruh Yigit wrote: > >> On 6/8/2016 10:47 AM, Nelio Laranjeiro wrote: > >>> Enhance mlx5 with a data path that bypasses Verbs. > >>> > >>> The first half of this patchset removes support for functionality completely > >>> rewritten in the second half (scatter/gather, inline send), while the data > >>> path is refactored without Verbs. > >>> > >>> The PMD remains usable during the transition. > >>> > >>> This patchset must be applied after "Miscellaneous fixes for mlx4 and mlx5". > >>> > >>> Adrien Mazarguil (8): > >>> mlx5: replace countdown with threshold for TX completions > >>> mlx5: add debugging information about TX queues capabilities > >>> mlx5: check remaining space while processing TX burst > >>> mlx5: resurrect TX gather support > >>> mlx5: work around spurious compilation errors > >>> mlx5: remove redundant RX queue initialization code > >>> mlx5: make RX queue reinitialization safer > >>> mlx5: resurrect RX scatter support > >>> > >>> Nelio Laranjeiro (15): > >>> mlx5: split memory registration function for better performance > >>> mlx5: remove TX gather support > >>> mlx5: remove RX scatter support > >>> mlx5: remove configuration variable for maximum number of segments > >>> mlx5: remove inline TX support > >>> mlx5: split TX queue structure > >>> mlx5: split RX queue structure > >>> mlx5: update prerequisites for upcoming enhancements > >>> mlx5: add definitions for data path without Verbs > >>> mlx5: add support for configuration through kvargs > >>> mlx5: add TX/RX burst function selection wrapper > >>> mlx5: refactor RX data path > >>> mlx5: refactor TX data path > >>> mlx5: handle RX CQE compression > >>> mlx5: add support for multi-packet send > >>> > >>> Yaacov Hazan (1): > >>> mlx5: add support for inline send > >>> > >> > >> I run basic checks to the patchset: > >> > >> There are various checkpatch warnings, all are warning or check level > >> > >> Patch 8 and 13 failed to apply with via git, -looks line line numbers > >> shifted a little, this is not a problem since eventually it applies but > >> just for your information. > >> > >> check-git-log is giving following errors, it is mainly case issue in Rx/Tx: > >> Wrong headline lowercase: > >> mlx5: resurrect RX scatter support > >> mlx5: make RX queue reinitialization safer > >> mlx5: remove redundant RX queue initialization code > >> mlx5: resurrect TX gather support > >> mlx5: check remaining space while processing TX burst > >> mlx5: add debugging information about TX queues capabilities > >> mlx5: replace countdown with threshold for TX completions > >> mlx5: handle RX CQE compression > >> mlx5: refactor RX data path > >> mlx5: add TX/RX burst function selection wrapper > >> mlx5: split RX queue structure > >> mlx5: split TX queue structure > >> mlx5: remove inline TX support > >> mlx5: remove RX scatter support > >> mlx5: remove TX gather support > >> Headline too long: > >> mlx5: remove configuration variable for maximum number of segments > >> mlx5: split memory registration function for better performance > >> > >> > >> It compiles fine. > >> > >> Regards, > >> ferruh > > > > Hi ferruh, > > > > In fact, It does not apply well on top the current DPDK master branch. > > > > I did able to apply on top of rel_16_07 branch using "patch" binary. but > if you think it doesn't apply well, any plan to send a new version? > > Thanks, > ferruh I am finishing the V2, with some small fixes (it will be more detailed in the cover letter). It will be sent in few minutes the necessary time to run the check-* scripts on it. Thanks, -- Nélio Laranjeiro 6WIND