From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0087.outbound.protection.outlook.com [65.55.169.87]) by dpdk.org (Postfix) with ESMTP id E2A188D28 for ; Tue, 21 Jun 2016 05:35:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NJA8HcSpEOB45L/x9M6Qv/Vw93m7j1pfRgFvZJWY0Js=; b=cgZ2Ms4oOAFO9KawNYqoDH9CslsNLAgbsMbgUikM9pk7NHf4GlChW3wiNfEBDvaOXT0acGrdxJjINtpG0eiFkq0i1Bs1xGlftRR87/Xvort9droRddZx6ni9hAUObWnpffG0IJ5nRG3QdDnXLk0BGMcb81psp9/pUNWv/63JMnE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (111.93.218.67) by BN3PR0701MB1718.namprd07.prod.outlook.com (10.163.39.17) with Microsoft SMTP Server (TLS) id 15.1.523.12; Tue, 21 Jun 2016 03:35:23 +0000 Date: Tue, 21 Jun 2016 09:05:01 +0530 From: Jerin Jacob To: "Ananyev, Konstantin" CC: Thomas Monjalon , "dev@dpdk.org" , "Hunt, David" , "olivier.matz@6wind.com" , "viktorin@rehivetech.com" , "shreyansh.jain@nxp.com" Message-ID: <20160621033459.GA4903@localhost.localdomain> References: <1463669335-30378-1-git-send-email-david.hunt@intel.com> <1466428091-115821-2-git-send-email-david.hunt@intel.com> <20160620132506.GA3301@localhost.localdomain> <3416153.NDoMD8TpjF@xps13> <2601191342CEEE43887BDE71AB97725836B73750@irsmsx105.ger.corp.intel.com> <20160620142205.GA4118@localhost.localdomain> <2601191342CEEE43887BDE71AB97725836B73B9B@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB97725836B73B9B@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0062.INDPRD01.PROD.OUTLOOK.COM (10.163.199.34) To BN3PR0701MB1718.namprd07.prod.outlook.com (10.163.39.17) X-MS-Office365-Filtering-Correlation-Id: e6352c3a-8229-4963-ed7e-08d399851559 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 2:xXsgTH0rayn8hkpUJG6a657P4YpUJLhwoDlgLblQknipB+K+AWa2fygYrv6tOtg21CZRSZCa5MNnSaGoMA6PR7QYMxgxtv69hw3rt+4VAiUSXpvFnNKPgkT3vCSfWeCQqVQ/6QMVkOxMMBdAbmFrxy/dmZCk2lTfozLiKPdKpwCXGvRuGpk36aIDFB1uPf7Y; 3:B86jn17tpGH28iuD8OffwxlbZfN4lXNnQDHkKo617t1okuSLAPY7M+Knl3MiqLGEGE5qlbioZYHOlCwZMg/rAHcwfNabekkCMcT6P+3hYsLYlmoPMcAwWOy97DDyyfdg X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1718; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 25:z7sdFHnJ19uvGEu1l/mnsiF0FNrObfWMmtHYhRZC6CWvaS7xrcpKgYIb0Z+Ghw7VglEP7fm2go6B7wyhv7KhVpaYevemo9ytqqNMTpHqq7aN+RoTfwymwTpzTSX7iqnPf0mqsiBNpKlWaHtxbDxTgt+mL2WecWvdnltbacAMf3D5tXltCjzPNMlAjliLeBa33Bop9CNVjiZDpHT2JdgW8FBUiNlhRYKIv+mVpJX4JYJ6v1oukZOuYaVDY92Qg2kTjpRzoF8KNKcBTO2VBeG2kIYMeOcfr6U7sIcDqz8eclVBCzaKtHwB1D4A+jENHK9GNMFYXUbCdGGBMtmqA5V4vweIxz96B0MYNUbca9pDw8fXivRQ4ls0k7zC+bz9hhHRUStHTlul07WgHGB2tNAgxuyfCriijTHKcUZstr934VmgCpWTKKtl4lmbqQcVa2/GVWmHfZuJt+gcI1qQP+CWhVDbn0Q1XAKhPzXzKturV5yLOlSD0VpB4S7Gn+agivE7iQzkUMxH3lsoxwAd5l6MWDNntepIbFlzCESv0vZUrO/q/DW5q17Umhl+AhVSFJiMMz/TF4bUIg07UDUTHVdsVsMy/j5ls5u4owNgfx3b1m1zkX2KY5Od+zDyj8HK6ec99PERnzDsbHHWZLmYgfg8ZaNYYcZMxOGSiqNDJw815bViOKYLK1KDkiBGyoK7iHFRz0llmM64dJvSOHpAKXzkVvFwloQfj+Q3cE0cXpPr8cw= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 20:SzyVtaKSS5pL0jHHgcJyQihRTfu41PLE1m9hvt1NwftrcCvZYx/F466mADkIbA8IQh4bz7DWhboMSeW0sXEUrNXOe+wHPUkjfXB8AuZYcW8bNAGWjsOJ9q1HCJvVHfX+2mYaiIGo5mxCgOYryCY8FF32ha+eQ9cQnT4Skvq+dhkuYUJoj4sGcPahiQC6ra3CDPlDZNSeTEU7VeVvZ90OruZjpR5by/5Wm0lx/NUJPAufJJrw3NUtlhSVAlc21g7OhoaG7UjJ8gb7ttllchQSVraoQDx5Z55yTwkbCT+avqii0+DYB2l/I/pbDcVh1PYjho5hq5XBt6Kz2AF+3b7abr8HIfvS4DJKkMa6KB5IGZyTpWh87N2HFSlTLybtTHm6ScKKjUNFrD+MXehmERJsmlZDHpaS4RhwdpeRCaNMZa68dkSYswwuHXQo7wm1W5BdIw0hN6Aj55yw/jomIHvwMgF30gQeZz14CJG/ychJGH0T0FbWoy5bD4ymIVgK6k6fYjJArF3j12cU8sod0WQGPMFPpuNLamdQCVvM8cWMcKqsoGFrCShGJqtvt/28Ek/6kZEueVSt/1Ywf2duwM0mFhfHm4FciQ/RJbdCT54iGG0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BN3PR0701MB1718; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1718; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 4:CLFObxkX+YoA6lZydu3Y66Q8uuq9T4vVGED+6VZ1T6vnFFfw2ULWaRrh+Vn3xroqyNSXL9EhDmq6AvUSdkABKlJOXxzI6Xs6RhJAHlIwfvd0nSALFyv0flexseUbWT9kTxODEGUW5fjt6whwxj6giFdqnDvHOVinI8Kp4yrTTTkRLVndxREVxPdQPYtEhoLn5kSf8aJKGimZnAjcVraY9L5gW+6S1T5h87JPNNx6ADIbFycCEtYjkLvnUVJH0ZuhS/t21mAgKQWcfepjlpWPXNXkr/NZlflv/396satQdbs30waWZfCzD1lpFMdgrBMu8+XjOm0Ko8Oe0+ykkcLxp16EEarhIxe8pfICUTE6d3xi/VMc0zUderSpUuBHmDtcmnVcuEhMVo8YoBH747phFvULirJZVsLFbrSg/m8a5T9vdd9g0p1cpUJAcw4UhuEp X-Forefront-PRVS: 098076C36C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6069001)(6009001)(7916002)(377424004)(199003)(377454003)(24454002)(13464003)(189002)(81166006)(81156014)(8666005)(8676002)(105586002)(7846002)(61506002)(83506001)(33656002)(68736007)(5009440100003)(2950100001)(106356001)(97756001)(97736004)(4001350100001)(77096005)(2906002)(47776003)(54356999)(76176999)(50986999)(66066001)(19580405001)(110136002)(189998001)(92566002)(46406003)(50466002)(6116002)(586003)(93886004)(9686002)(4326007)(101416001)(19580395003)(23726003)(3846002)(7736002)(1076002)(42186005)(7099028)(7059030)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1718; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1718; 23:47WoJUfvb4H6HwxBOL4G3bibU63wTVjuBnX6J7p?= =?us-ascii?Q?SD8ePRxzoU0usITMPsUJF301vHd0njCuzThVNsi0u+7PAJanyAR+tWy3gMtq?= =?us-ascii?Q?o8vJJ1efVD+Uceonwr5+Y6EgVX9vt/TeWguDIi8Y7nL4H65ysMrt8/fxnz1g?= =?us-ascii?Q?PJOL1iNeofLlqfsJO9oLF+J8Gpeef7myFI00y+gprIZXQl/mcg3KfgcRO6IH?= =?us-ascii?Q?JKTPzmhTcfcKHo0Y4XGWf6tlpRE4LDK5Nt5aRogq9a58IyhCaNZ9XJrV/ASd?= =?us-ascii?Q?Ko/YkiIvWbHrquJTbPziwXWRl+gzwAXlPisM10B79mf9JW9vIoCy5VGsHvFc?= =?us-ascii?Q?MgRGDrcUOvuYT0/LoXa7nLreOIugrRLwb6z2cML1+xttrehDbph0HRaOgOR/?= =?us-ascii?Q?25QZoiiquXjPSMn2L7FZPrghgMOQSfY2bb39jcuaTGK/7n5dK2LgysXIASWB?= =?us-ascii?Q?lCqW5IZmiTYRSRghavCuUdOf4HaY3reLDSK6zNk5v8i7dGzl/PGKIKCYxQEl?= =?us-ascii?Q?DckZIfqTUpi8m+FFweO/KZV97WAl/OmCURcrBEjKkqGF5g/7JHqRXQQsKhSJ?= =?us-ascii?Q?FkSqV/BZZlHJVF3J13LIqmN6Z8qjQUF0yGt3mIVwz1hvWcYQA2qEN3WzETb/?= =?us-ascii?Q?bI8j0rlJ41yy6rhA9p4euxAfS5IxvZdSMT2arMCG08HdpYbJ91NyC8Lxi7rB?= =?us-ascii?Q?c9R27nKqWvC/TOY+qSjay4T/11GRGqTmH6yak8viXNDp5dwUUSU3oWbjQu3F?= =?us-ascii?Q?QGtbJOP6QI0c/q9QP/vOKXNIDuGWzIaV+xRuv4PkkCAm2mmtj63UZpcY/2Y1?= =?us-ascii?Q?u9YswppnMlhAB8WcgW28mAu9j9l7qGhCs5LROngTB6LJcaV9Fjk90PWvl5KN?= =?us-ascii?Q?liO4KIx4Q5LSOS99w5OcN0v7hPukV6RBhFXZmlvY58bgVDA5HtFcqR0Ch79+?= =?us-ascii?Q?Kq1Cx6yCZl9ZyDJoU4/3pkKovcVvRSB5mqz8k5cOWbECPII2l8slsPnWhTu4?= =?us-ascii?Q?UGLM8ZHkHwGjMG66cFQQp8uo3txA413TqddqohIqn0gDAxBRC5UU9+sTTNnD?= =?us-ascii?Q?xtxdn1esHFltM3mYt0M4W7u4qLcXSOgy6nHbE+Tw47bMLLJBpCSMxOrpsCaW?= =?us-ascii?Q?4R0i442jjmz9Qku0s220/uOC/ZEVQvoPdIc/FbU343KyKJRLniFSnB5tm05e?= =?us-ascii?Q?/bzqLTMnKwOvliylnMgvd/HU3WxcLXkkUlii9DwvUoHLxGS0hu9onLhIX3xI?= =?us-ascii?Q?hrPvYS6y48pK+pjcTYtdxrKTTSL3y4e2LK85MmUMqaoi+FkzL260laYbX/SD?= =?us-ascii?Q?kKhD25iKGJMLVG8Dnb4DeNLkEhnTbh834FKzyvjY6436Ep5MqOcizEZZ9Fsp?= =?us-ascii?Q?okddhTO9Gu+mB3T/MLIqQSjTD5TccvqQ3M7Ig2CG6wJhrtDVo?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 6:GW4YvYzozRtNGlZh+OV6HuButq0alMGdJ0mKuIPegz2Exkt6eYjNefjXPtHcGxpa2WS8BlBOX+fOqerINhhS33rkWEpqNeJxIIfyK8kTuvSInNM81sNzpk56RL2hX8Xcs5QU4I35glvdIFWQrudBY4ve3k+4dg++XHkZS5QY+szipMHBxeETVRkY3/TXluK7FGvksscJjd99XNGUREkd8V2Wh9UOG9kQ1OIm5aY1zVhfdUqWnN2WedR9CBsBawSTvG7BOOknrzhJucc7dnmF59V8tjyDWKKfB1GFxzB0gWY=; 5:mtS2veZV2iiVoVvGu9GAjqiYieE7sM2+Qqk/6s0dI2wDpGmoMeDGbqlRql0CcCYeD0yBpVHQS/A5t6UoS8yj1Zh0xsKLA1JSxWEQIyC55hlxNcu3Rvri3Y5FLzCwZEl9Jsc1ftUu2owcbpadijGIAQ==; 24:TboY9M0+qKJ1uRhN7BDDRPRGUMUuhV8yUKeP7098N/gZDO3wlOlXzOPIV4j1xzr0vznkbfXxKX5BHZwW7abPuUhRO65J24xGYB55sdu94+Y=; 7:BpoIKoqR1gjXnuGali0g3++1GFRyesceLtH7ETVKbyRO4Mho5cUfLnSdP6CvVjwmMgdyxFdF714bLA/NVSPjDXDTIbeb+RIkUa1A9rNWgKRbL5pGGcXOG8/a5Dc9P5lKpLNCKx+jKJXbn4wX3+xaui05qxfsTCTel9LDW+fuGyqwjhdz/psqeix2sBVQmJmiaoKNxFA2sl+sddpXCGp51VqWfBORQggXTJh9TgRS/mGXDp/imDISDumZ2CLNZemg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 03:35:23.0095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1718 Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 03:35:29 -0000 On Mon, Jun 20, 2016 at 05:56:40PM +0000, Ananyev, Konstantin wrote: > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Monday, June 20, 2016 3:22 PM > > To: Ananyev, Konstantin > > Cc: Thomas Monjalon; dev@dpdk.org; Hunt, David; olivier.matz@6wind.com; viktorin@rehivetech.com; shreyansh.jain@nxp.com > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler > > > > On Mon, Jun 20, 2016 at 01:58:04PM +0000, Ananyev, Konstantin wrote: > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > > Sent: Monday, June 20, 2016 2:54 PM > > > > To: Jerin Jacob > > > > Cc: dev@dpdk.org; Hunt, David; olivier.matz@6wind.com; viktorin@rehivetech.com; shreyansh.jain@nxp.com > > > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler > > > > > > > > 2016-06-20 18:55, Jerin Jacob: > > > > > On Mon, Jun 20, 2016 at 02:08:10PM +0100, David Hunt wrote: > > > > > > This is a mempool handler that is useful for pipelining apps, where > > > > > > the mempool cache doesn't really work - example, where we have one > > > > > > core doing rx (and alloc), and another core doing Tx (and return). In > > > > > > such a case, the mempool ring simply cycles through all the mbufs, > > > > > > resulting in a LLC miss on every mbuf allocated when the number of > > > > > > mbufs is large. A stack recycles buffers more effectively in this > > > > > > case. > > > > > > > > > > > > Signed-off-by: David Hunt > > > > > > --- > > > > > > lib/librte_mempool/Makefile | 1 + > > > > > > lib/librte_mempool/rte_mempool_stack.c | 145 +++++++++++++++++++++++++++++++++ > > > > > > > > > > How about moving new mempool handlers to drivers/mempool? (or similar). > > > > > In future, adding HW specific handlers in lib/librte_mempool/ may be bad idea. > > > > > > > > You're probably right. > > > > However we need to check and understand what a HW mempool handler will be. > > > > I imagine the first of them will have to move handlers in drivers/ > > > > > > Does it mean it we'll have to move mbuf into drivers too? > > > Again other libs do use mempool too. > > > Why not just lib/librte_mempool/arch/ > > > ? > > > > I was proposing only to move only the new > > handler(lib/librte_mempool/rte_mempool_stack.c). Not any library or any > > other common code. > > > > Just like DPDK crypto device, Even if it is software implementation its > > better to move in driver/crypto instead of lib/librte_cryptodev > > > > "lib/librte_mempool/arch/" is not correct place as it is platform specific > > not architecture specific and HW mempool device may be PCIe or platform > > device. > > Ok, but why rte_mempool_stack.c has to be moved? Just thought of having all the mempool handlers at one place. We can't move all HW mempool handlers at lib/librte_mempool/ Jerin > I can hardly imagine it is a 'platform sepcific'. > From my understanding it is a generic code. > Konstantin > > > > > > > Konstantin > > > > > > > > > > Jerin, are you volunteer?