From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 477F5C4C0 for ; Thu, 23 Jun 2016 12:13:37 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 23 Jun 2016 03:13:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,509,1459839600"; d="scan'208";a="127185968" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.161]) by fmsmga004.fm.intel.com with SMTP; 23 Jun 2016 03:13:34 -0700 Received: by (sSMTP sendmail emulation); Thu, 23 Jun 2016 11:13:33 +0025 Date: Thu, 23 Jun 2016 11:13:33 +0100 From: Bruce Richardson To: "Wu, Jingjing" Cc: "Xing, Beilei" , "dev@dpdk.org" Message-ID: <20160623101333.GA5024@bricha3-MOBL3> References: <1463127333-10007-1-git-send-email-beilei.xing@intel.com> <1463757424-2010-1-git-send-email-beilei.xing@intel.com> <9BB6961774997848B5B42BEC655768F80E134394@SHSMSX103.ccr.corp.intel.com> <20160609142343.GC12520@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160609142343.GC12520@bricha3-MOBL3> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4] i40e: configure MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 10:13:37 -0000 On Thu, Jun 09, 2016 at 03:23:43PM +0100, Bruce Richardson wrote: > On Mon, May 23, 2016 at 01:33:42AM +0000, Wu, Jingjing wrote: > > > > > > > -----Original Message----- > > > From: Xing, Beilei > > > Sent: Friday, May 20, 2016 11:17 PM > > > To: Wu, Jingjing > > > Cc: dev@dpdk.org; Xing, Beilei > > > Subject: [PATCH v4] i40e: configure MTU > > > > > > This patch enables configuring MTU for i40e. > > > Since changing MTU needs to reconfigure queue, stop port first before > > > configuring MTU. > > > > > > Signed-off-by: Beilei Xing > > > > Acked-by: Jingjing Wu > > > Applied to dpdk-next-net/rel_16_07 > > /Bruce It has been brought to my attention that there were still outstanding comments and issues with v3 of the patch that were never resolved, therefore this patch may need to be reverted, as I should not have applied it Maintainers, please do not ack patches for your components if there are still unresolved discussion on them! Once the component maintainer acks a patch I should not have to go back through the whole patch history to determine if it can be applied or not. Regards, /Bruce