From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 98D44C506 for ; Thu, 23 Jun 2016 17:47:34 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 23 Jun 2016 08:46:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,517,1459839600"; d="scan'208";a="724000712" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.161]) by FMSMGA003.fm.intel.com with SMTP; 23 Jun 2016 08:46:56 -0700 Received: by (sSMTP sendmail emulation); Thu, 23 Jun 2016 16:46:55 +0025 Date: Thu, 23 Jun 2016 16:46:55 +0100 From: Bruce Richardson To: Rasesh Mody Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, Sony Chacko Message-ID: <20160623154655.GN5024@bricha3-MOBL3> References: <1466056031-23225-1-git-send-email-rasesh.mody@qlogic.com> <1466056031-23225-9-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466056031-23225-9-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 8/9] qede: update vport filter settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 15:47:37 -0000 On Wed, Jun 15, 2016 at 10:47:10PM -0700, Rasesh Mody wrote: > From: Sony Chacko > > Enable promiscuous mode filter settings. > Check for VF mode and enable promiscuous mode settings for VF. > Check filter configuration to ensure conflicting filter modes > are not set. > > Signed-off-by: Sony Chacko I think the title on the V1 patch is actually a better one for this patch as it describes the overall goal of the patch rather than talking about the low level details. On apply, I'll therefore merge in the title and intro from the V1 patch with the additional detail in the commit message from this V2. Regards, /Bruce