From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 6A1A95A90
 for <dev@dpdk.org>; Mon, 27 Jun 2016 10:46:53 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga104.fm.intel.com with ESMTP; 27 Jun 2016 01:46:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,536,1459839600"; d="scan'208";a="1005800370"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.54])
 by orsmga002.jf.intel.com with SMTP; 27 Jun 2016 01:46:51 -0700
Received: by  (sSMTP sendmail emulation); Mon, 27 Jun 2016 09:46:50 +0025
Date: Mon, 27 Jun 2016 09:46:49 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
Message-ID: <20160627084649.GB19588@bricha3-MOBL3>
References: <1757902E-701B-4C42-BF80-285F37F50526@intel.com>
 <1466956452-91772-2-git-send-email-keith.wiles@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466956452-91772-2-git-send-email-keith.wiles@intel.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 2/2] fix building with clang-3.8.0 compiler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jun 2016 08:46:53 -0000

On Sun, Jun 26, 2016 at 10:54:12AM -0500, Keith Wiles wrote:
> Latest clang compiler 3.8.0 on latest update of Ubuntu
> creates a few more warnings on -Warray-bounds and extra
> () around 'if' expressions.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  app/test-pmd/Makefile                | 3 +++
>  app/test/Makefile                    | 3 +++
>  drivers/net/bonding/Makefile         | 4 ++++
>  drivers/net/fm10k/Makefile           | 2 ++
>  drivers/net/i40e/Makefile            | 2 ++
>  lib/librte_cmdline/Makefile          | 6 ++++++
>  lib/librte_eal/linuxapp/eal/Makefile | 8 ++++++++
>  7 files changed, 28 insertions(+)
> 
All the fixes in this patch seem to be just disabling the compiler warnings, which
should really be the last resort in cases like this. Can some of the issues be
fixed by actually fixing the issues in the code?

/Bruce