DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: limit number of forwarding cores
Date: Tue, 28 Jun 2016 10:41:34 +0200	[thread overview]
Message-ID: <20160628084134.GU14221@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <1467066919-135951-1-git-send-email-pablo.de.lara.guarch@intel.com>

On Mon, Jun 27, 2016 at 11:35:19PM +0100, Pablo de Lara wrote:
> Number of forwarding cores must be equal or less than
> number of forwarding streams, otherwise two cores
> would try to use a same queue on a port, which is not allowed.
> 
> Fixes: f2bb7ae1d204 ("app/testpmd: handle all Rx queues in RSS setup")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  app/test-pmd/config.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 9ccabf9..de60284 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1236,6 +1236,10 @@ rss_fwd_config_setup(void)
>  	cur_fwd_config.nb_fwd_streams =
>  		(streamid_t) (nb_q * cur_fwd_config.nb_fwd_ports);
>  
> +	if (cur_fwd_config.nb_fwd_streams < cur_fwd_config.nb_fwd_lcores)
> +		cur_fwd_config.nb_fwd_lcores =
> +			(lcoreid_t)cur_fwd_config.nb_fwd_streams;
> +
>  	/* reinitialize forwarding streams */
>  	init_fwd_streams();
>  
> -- 
> 2.5.5

Tested with:
 - coremask allowing to use 12 cores for 4 txqs and 4 rxqs.
 - coremask allowing to use 12 cores for 6 txqs and 6 rxqs.
 - coremask allowing to use 12 cores for 8 txqs and 8 rxqs.

It fixes the issue.

Tested-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> 

-- 
Nélio Laranjeiro
6WIND

  reply	other threads:[~2016-06-28  8:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 22:35 Pablo de Lara
2016-06-28  8:41 ` Nélio Laranjeiro [this message]
2016-06-30 17:23   ` Thomas Monjalon
2016-06-28  9:58 ` Mcnamara, John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628084134.GU14221@autoinstall.dev.6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).