From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix O_CLOEXEC undeclared error
Date: Tue, 28 Jun 2016 17:02:54 +0800 [thread overview]
Message-ID: <20160628090254.GZ23111@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1466948986-12255-1-git-send-email-jianfeng.tan@intel.com>
On Sun, Jun 26, 2016 at 01:49:46PM +0000, Jianfeng Tan wrote:
> On some older systems, such as SUSE 11, the compiling error shows
> as:
> .../dpdk/drivers/net/virtio/virtio_user/virtio_user_dev.c:67:22:
> error: ‘O_CLOEXEC’ undeclared (first use in this function)
>
> The fix is to declare _GNU_SOURCE macro before include fcntl.h.
I think you need give a reason how that error comes and why this
would fix the error.
And if you look at the git history, you might want to define this
macro in Makefile. See commit e49680a87e06 ("mk: compilation fixes").
Last, don't forgot to run ./scripts/check-git-log.sh against your patch.
--yliu
next prev parent reply other threads:[~2016-06-28 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 13:49 Jianfeng Tan
2016-06-28 9:02 ` Yuanhan Liu [this message]
2016-06-28 9:41 ` Ferruh Yigit
2016-06-29 1:56 ` Yuanhan Liu
2016-06-29 3:23 ` [dpdk-dev] [PATCH v2] net/virtio-user: fix build error in SUSE 11 Jianfeng Tan
2016-07-01 2:10 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628090254.GZ23111@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).