From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AF25ADE3 for ; Tue, 28 Jun 2016 13:09:38 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 28 Jun 2016 04:09:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,541,1459839600"; d="scan'208";a="726182290" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.92]) by FMSMGA003.fm.intel.com with SMTP; 28 Jun 2016 04:09:37 -0700 Received: by (sSMTP sendmail emulation); Tue, 28 Jun 2016 12:09:35 +0025 Date: Tue, 28 Jun 2016 12:09:35 +0100 From: Bruce Richardson To: Nelson Escobar Cc: dev@dpdk.org Message-ID: <20160628110934.GC22860@bricha3-MOBL3> References: <20160623113608.GH5024@bricha3-MOBL3> <1466723698-3202-1-git-send-email-neescoba@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466723698-3202-1-git-send-email-neescoba@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] enic: fix free function to actually free memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2016 11:09:39 -0000 On Thu, Jun 23, 2016 at 04:14:58PM -0700, Nelson Escobar wrote: > enic_alloc_consistent() allocated memory, but enic_free_consistent() > was an empty function, so allocated memory was never freed. > > This commit adds a list and lock to the enic structure to keep track > of the memzones allocated in enic_alloc_consistent(), and > enic_free_consistent() uses that information to properly free memory. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley Applied to dpdk-next-net/rel_16_07 /Bruce