From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 65A8D1396
 for <dev@dpdk.org>; Wed, 29 Jun 2016 12:39:26 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga102.jf.intel.com with ESMTP; 29 Jun 2016 03:39:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,546,1459839600"; d="scan'208";a="1011924577"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.81])
 by fmsmga002.fm.intel.com with SMTP; 29 Jun 2016 03:39:08 -0700
Received: by  (sSMTP sendmail emulation); Wed, 29 Jun 2016 11:39:07 +0025
Date: Wed, 29 Jun 2016 11:39:07 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org,
 thomas.monjalon@6wind.com
Message-ID: <20160629103907.GG4720@bricha3-MOBL3>
References: <1467044166-31912-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <57723B9B.8070209@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57723B9B.8070209@intel.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: select
 -fno-prefetch-loop-arrays only for gcc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 10:39:26 -0000

On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote:
> On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang
> > 
> > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> check-git-log gives following errors:
> 
> Wrong 'Fixes' reference:
>         Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx
> functions")
> 
> This looks like because of missing " in the beginning

Yes, but I can fix that on apply.

Other very minor nit is that the standard for fixes lines is to use a 12-char
commit id, rather than 8. Per contributors guide:
   git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'"

/Bruce