From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B32641396 for ; Wed, 29 Jun 2016 12:43:12 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 29 Jun 2016 03:43:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,546,1459839600"; d="scan'208";a="1011926619" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.81]) by fmsmga002.fm.intel.com with SMTP; 29 Jun 2016 03:43:10 -0700 Received: by (sSMTP sendmail emulation); Wed, 29 Jun 2016 11:43:09 +0025 Date: Wed, 29 Jun 2016 11:43:09 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Jerin Jacob , dev@dpdk.org, thomas.monjalon@6wind.com Message-ID: <20160629104308.GI4720@bricha3-MOBL3> References: <1467044166-31912-1-git-send-email-jerin.jacob@caviumnetworks.com> <57723B9B.8070209@intel.com> <20160629103907.GG4720@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160629103907.GG4720@bricha3-MOBL3> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2016 10:43:13 -0000 On Wed, Jun 29, 2016 at 11:39:07AM +0100, Bruce Richardson wrote: > On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote: > > On 6/27/2016 5:16 PM, Jerin Jacob wrote: > > > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang > > > > > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions") > > > > > > Signed-off-by: Jerin Jacob > > > Reported-by: Ferruh Yigit > > > > check-git-log gives following errors: > > > > Wrong 'Fixes' reference: > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx > > functions") > > > > This looks like because of missing " in the beginning > > Yes, but I can fix that on apply. > > Other very minor nit is that the standard for fixes lines is to use a 12-char > commit id, rather than 8. Per contributors guide: > git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'" > > /Bruce Applied to dpdk-next-net/rel_16_07 /Bruce