From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Jerin.Jacob@cavium.com>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1bn0100.outbound.protection.outlook.com [157.56.110.100])
 by dpdk.org (Postfix) with ESMTP id 2AE2E2BD0
 for <dev@dpdk.org>; Wed, 29 Jun 2016 13:19:13 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=L5+LU1oPwLxygyZ2+2Q6ThJapRLFk/fuLly1MZLiGBI=;
 b=Eo8UH9PafKpOkpMTO4Yu26AKRT8H7xwSi8hAxY9nSqXfm3WWUq3NbMoahAN2OXX20URyjhp1i/KxgG0tqqWLN50a7XUf44+nELQlia0oAm1Cac92CQUnLCiPjXwseyn5zsRUKRqQHfqR6AFxQr2aAwmHCYBQzha0n/UGzbUAgXg=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jerin.Jacob@cavium.com; 
Received: from localhost.localdomain (122.167.198.169) by
 CY1PR0701MB1727.namprd07.prod.outlook.com (10.163.21.141) with Microsoft SMTP
 Server (TLS) id 15.1.528.16; Wed, 29 Jun 2016 11:19:08 +0000
Date: Wed, 29 Jun 2016 16:48:49 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: <dev@dpdk.org>, <bruce.richardson@intel.com>, <jianbo.liu@linaro.org>,
 <huawei.xie@intel.com>, <yuanhan.liu@linux.intel.com>
Message-ID: <20160629111848.GA5301@localhost.localdomain>
References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <2275187.xVvf3fOqxc@xps13>
 <20160627144829.GA25422@localhost.localdomain>
 <3436400.asiby3BQPB@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3436400.asiby3BQPB@xps13>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Originating-IP: [122.167.198.169]
X-ClientProxiedBy: PN1PR01CA0052.INDPRD01.PROD.OUTLOOK.COM (10.164.136.152) To
 CY1PR0701MB1727.namprd07.prod.outlook.com (10.163.21.141)
X-MS-Office365-Filtering-Correlation-Id: f1b285a2-2fae-4363-b734-08d3a00f31d7
X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727;
 2:EXjdyJCJnjw12ZRRFYO0mZusYo67bPhY5KQGjhjxbypKszKiWWYEH/1MjDoBaLnbKFLqrp94L+HlqOJMQ81onOZAngEVlfzUhM004ovTjtWFYQnY3oWSikkcec9YyZdmX0YvMob5LTJ+R5t82fUqGRigas1qFO9yir3sqrM66d0/FK7fZ21Z4TPd1Z7/CUi0;
 3:QAzmhL31X51l0igxyPXYxeE6WZDIyv1UCTimpZPHU5Yrahr6rMOgHVT2u7FL0DCOdM9iso1pjkyLgMHMGY99z61mkTJuBW5rsBDdYmoB14Viri88n6XF3PZhr7dm0Ipx
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1727;
X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727;
 25:GHtCikvdpaS/g9LRa74PG/MUUNhOBE7ajh+PVc9XDWdd89sTs6petVpQQAwLBKRTcs2R6cXajO8YuLcyrISLAJckAF7sJ8+1z7cpVVvwhDBTwxmDUXmFwKxSkduN6kGxPxRkWKHtfK+Tucqxo3BH6U7UBuvmpgaiylZx1/Lt/6+BDxpUyPNoFAL8ur4bmwiuzoDl1Ku++xRqrRwM447DqEBjQ4de3LzwKSxWYhI2kPyHU+ymeGVgS5ilyy/MZRtCbBTjWRajG5ASuyslUs5jZsw0dA0gAoknN6ywl8HgswbXFpwbNzHAatPcSVqQkom5b/S0zAgDogmIFHngpCcrBWsCtEd9ITppy16ptm62Ytza4g6gzGDfs1rwJXrlB7fpzQSnDaYUsU+9ZwfDEy00U6VH42lm0vQnVS7U6b99+NwtO/j1chsYUKAvBnj2zkFheX9uCN03m/KIWHH9kqvRvxp+InLFg2HEfmh2Lu+/m6gXOw3w/Ac9fPmlRDn3t8RH4tPLoo7pjnpJ5xWf2E4eZUQRsItHmYSo0J7q3Rj1oh2dBmjqe+FR3fCNed7Bw4vmX45F3GWIV11d+0aF/tD5Fd7E7WPcPnqM86K6HhjQYwVY3m1tkG5OZyIqw0HWu3+7K9m2HkjzpS377MQq0E35QPas+vluBKgaEN3bjG9Y59CS17HRtnbdhbpcYK6R/aIKfDA/swAkJsRpXvsUEKG/xPTtZfGoboMKtEDRC31cc7o5etXDDa9nirp3Pk0H+STZfRB3ysK7zyhoGLHNucF6Uw==
X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727;
 31:YFqTWv4vhHNuCol861vR5cT8mDPfT3A/F/ADuBC09Wg+mDpwFguI1CQ7QO7Zsr2sFUVhDADOJ4tK2+XkXcLd+gQHNOsqYdAp1w+2zY+wKYcRr1xfQpapumsf0YRxii8dWkIPIiflsyKMEVXlW/XsenhxBksiqJItLHmm3u33mztGoHxp+KK389oYIQSeUIJjLzZycsJZ/AKfTonWaV2eVA==;
 20:Jy7V1EYSsUYD9AYc1wfyzAYiy/nXCVOtKmffDW30Ur4mJaidLfYiRzmEEXkSxCjXXf6InZiZBwKzt87Xwh7yK3pgcxk+wyOfbYHmvioaX65iZPFTuI1zwNb9nSPDK08Y+JCBaIjg2e8RGugEkiM07Zfid/94h+Cn+4VJpe5XMoI4QPHlQXaqHF9u7Fmmz9rSEuJAPlDpM+Wj2vsbSGSaJk3O6QMQTMR6Hea9F6WsHeSlrTjzKVO1d2taivIuI5P1xKnoAR8Btah00WSBsvVNTm1H62paPYNDGwr+fnYU6E0xynLMbZlx3nXl+KkaBrxbJQ5R34MOxvAvgDXqcOspW1D646LZiXqFOgPjrN3rxACkzMsAMhY40YW0aGdSrTUuaDftOaRBkuHKD7y/EMAhIOxzbIVQRrDIwDRI61N+H1yNLvgIq8VFwOAxEbNFUmY5FyWrFXjeDSAsl2Ow0MgIE85Vmo5v19UwxivjibS+9LctmdRw2BzTrg/wtwMQdT37pPDAaq4uVz1XqGtrxtvAgqf76TLzmdJHQkINz2Y4ZKra6JIb8FodbiFaFZR9ruLNCe5A/QuFZ17xJb8KjxhHQk0qvcOsj6cCPXWlR5e8lLs=
X-Microsoft-Antispam-PRVS: <CY1PR0701MB1727E2E5D610AFFEBA66DE6F81230@CY1PR0701MB1727.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);
 SRVR:CY1PR0701MB1727; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1727; 
X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727;
 4:KdoWV38wRRGpHniobWTQJadO/0VdkpoWW0+9YVhSMP+GjCaiJoM1RK6wWkTz4xDk1LrGlYQhC/fBbKxix37M17dshhtKDTfINRODKPrugxIdumxzj5Du3CD4ykTRA30KjR5nisCoD9qSLJUCZbMSWCtc6DK6VfWoO6JUTbZfd7OYxCLeBJwjIY8nsioTRh8OUvLXcZIFB3XyA8ujT0QIVxvlD0hegYsTZycQB2np5efzznjoweWNWWa6dON4vnBwchoLyMHzVYZblPnbPMkmtlM3a7vYDBQlONG93E8mAgRXOEBonZxJ6SdnzB+njlErAn946fT6r1i8muK9G0ihOC3iWWWQni753xNP7mX92FOnZ/MDjKD/JWdZ5Tz5Gq27
X-Forefront-PRVS: 09888BC01D
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(189002)(377424004)(199003)(24454002)(2950100001)(42186005)(97756001)(189998001)(4326007)(2906002)(4001350100001)(93886004)(106356001)(23726003)(3846002)(1076002)(6116002)(76176999)(54356999)(97736004)(33656002)(110136002)(50986999)(305945005)(83506001)(586003)(101416001)(105586002)(68736007)(47776003)(7846002)(7736002)(81156014)(77096005)(61506002)(81166006)(9686002)(92566002)(66066001)(8676002)(50466002)(46406003)(7099028);
 DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1727; H:localhost.localdomain; FPR:;
 SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1727;
 23:4QizNmFmMVOOOT1yRqmm1xAOSe3DcoAz2z69H7C?=
 =?us-ascii?Q?OieQVuSm3Nks234aix59odl0tVlOh07sX6gh1jcTWzD/+KAHXNEoTs790oWv?=
 =?us-ascii?Q?Tj9qsDYlDMqtf47ruHGa4cCfhZ1qPHTmpPJOhQ3B+2Zgb8umpq61SLtcdzis?=
 =?us-ascii?Q?fmD7wdbGFo5FgjoP5Vfh3C27DUdOOyuyA4862s9BL60T0SI9GEpvfos2xQF9?=
 =?us-ascii?Q?k+MqgWLkMHbPoiMo+1gl6NUq8c+7IzSFUnMgoJUZLz1dmu3f36HPwrm+hC1f?=
 =?us-ascii?Q?qYEEesl29+hK9g5/C1B6ya6kTzLmBMA1V4pVfGtbp8vQqmLLv5dJXfVqUTaK?=
 =?us-ascii?Q?eFFrZC2/NUgFI1Z5DIoAgjqoj2aOiS18iNb3NpiqlBuryOoeyonlqnKxSZki?=
 =?us-ascii?Q?StweSU10bDmtlFpHS8EPolAwD+iCJYcjEO77lSXJ7SjkomRtqHDqiE9uuNtw?=
 =?us-ascii?Q?E12h/kYgTt+OEyXVLR3+1LfUbLRZ2qEtL3OtvpjlNgG3FqdZdyENfEFqgxCf?=
 =?us-ascii?Q?XcU2AMqVH9XnU9IGeZdJ4WNjou7BHDM6I/1DbhBDoqkCLDHEuO68bKFsXkny?=
 =?us-ascii?Q?CaIIJIaFad/Tk4CMrKjz9cBEeNp2ROvpivYDmZJeyyS/zz1KFhiF9XjYE/UZ?=
 =?us-ascii?Q?pIN+31fpoKvVXq0y+n0l1Y1kdBpKIFiUPDGMuFZRoBwrHQ6lmAYPxRZlJGCs?=
 =?us-ascii?Q?mwYQ50w5kS6zpdCszHMtJOX07GjH4SnxL8OSV7FkDJKuYx2WmLqzvqc/2j+l?=
 =?us-ascii?Q?JU00SxChwk57E154guSP+WQkMEv5eIDGEGgw7b5yyHXZB4jjOv/X6nNHRY0Z?=
 =?us-ascii?Q?uf8x1PyX9Mw5iaifMcANNBB8XE43zVRqEfrxu5pYrMWpSjdIvAy3q71pO2iO?=
 =?us-ascii?Q?hzTTZO4KNFmsVanewHKAVvcSaWjoZsu1Oi3Y7N8aMKm4GJWT33iEPWnJVcDC?=
 =?us-ascii?Q?ygHCFQHXusTlvbgeEIIfFtM6uCDyMcLP5QL7SZgNzeWtdMlG/fBjXJCkfZqg?=
 =?us-ascii?Q?qNjWi8CwciU166Y0FybX9O+0YNXve2adXCDrm+hG6lctnRtIuyp+a9B06r5I?=
 =?us-ascii?Q?0fxxvVKhKbSDbOYsPQGz3r++wSglEIIMy1+64LDgO4pHlxhtcqIj5dW0xdlp?=
 =?us-ascii?Q?sNpXE1itkjT5ijGgIPjzvRwRGib1X13tEsyFgOVO4qhhAurrts7We4Q=3D?=
 =?us-ascii?Q?=3D?=
X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727;
 6:VykB4l2OZveeVR2a9LHX6se1spIeCOFZhMLHz6BoBkfmKU47fAeI+q/d5xNltSYdgJu/h0p2gBp5V1eMdoRoc+oRGe/+mjpIjGIggkFQ2JOCWNWBrzNDoY2iy+ullW11aNeijbJXDINEIos9oAih1/8Tk0k3/5UPMJSUP1PELVBbYNYVe3CfgJYpa/RjEIVerzieFmyX+skDbd1urY9LZEJW/Pzp2wNe/DjOGyrsDVaixN381FMYO5iCXTjnt5Rkznt+amCpBYuHCsMFn/9d4S72Zz3aqrXkNkWxcc2R6w8=;
 5:pt6Wto6bUQRzB06IaCrRD2+F0cjHVbsrhRlPTLikZA/403ekCR2hkkQw13X+Ufx2fv/wKJjnmlU4Ahc45wfHIwo7Fnt+hBnhRYEsYhek/VAXA341yRpeR9USah+Fb8j3vbSTQ41yKyl5tlWCi7CGvQ==;
 24:KqM63AppTCS/llSMKaq0ueDOJy/ICyqyivl4G9BrsE1DMBJV3L7NReyKo6OqVUNJ3daYgXU329WLJU0UfPGAJwcg02J6vUXXQysxR+Pqtek=;
 7:3Z4HyYN0bS9L510BXKb59aCoMGpoG6DgTdMo325h89Na+9i3GqIDn3MC2HOwx4D8nZC5jSKq8P6MtOYCr6h6ggKYutDd2iQX+xZW7xGPMViel4hXovw5ZklmTHELUqmuD3tWCWqbogCx9oywhVA4PQe6a1vlacY1pMMtmBfKD+140GOmLPQaX6CRjetXH1Jne5tdj79RVmau+g/wLoPpzTLSgJQmUOovRrxQSM3pLdGzlk2o3rNcwf4Lek0w+nYI
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2016 11:19:08.3911 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1727
Subject: Re: [dpdk-dev] [PATCH 2/4] virtio: introduce
 RTE_LIBRTE_VIRTIO_INC_VECTOR
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 11:19:13 -0000

On Mon, Jun 27, 2016 at 04:59:42PM +0200, Thomas Monjalon wrote:
> 2016-06-27 20:18, Jerin Jacob:
> > On Mon, Jun 27, 2016 at 04:19:57PM +0200, Thomas Monjalon wrote:
> > > 2016-06-27 17:24, Jerin Jacob:
> > > > --- a/config/common_base
> > > > +++ b/config/common_base
> > > > @@ -267,6 +267,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n
> > > >  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n
> > > >  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
> > > >  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
> > > > +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=y
> > > 
> > > I don't remember what means INC_VECTOR?
> > > Why a config option is needed for vector implementations?
> > 
> > I thought of adding additional configuration option(INC_VECTOR) _apart_ from
> > cpu flag based scheme in the patch because even though if a given platform
> > has cpu instruction support, in some platforms scalar version may
> > perform well wrt vector version(based on instruction latency, emulation required or not
> > etc). So a top level flag INC_VECTOR, can override the vector selection
> > for a given platform if required.
> 
> Isn't it a runtime driver option needed to disable vector virtio?
> 
> > Regarding INC_VECTOR(INC in vector configuration name, I have no idea, I
> > followed the existing flags)
> > $ grep "INC_VECTOR" config/common_base
> > CONFIG_RTE_IXGBE_INC_VECTOR=y
> > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
> > CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
> 
> If the flag is really needed I would suggest VIRTIO_VECTOR.

OK I will change to VIRTIO_VECTOR