From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix implicit int to enum conversion
Date: Thu, 30 Jun 2016 13:28:33 +0800 [thread overview]
Message-ID: <20160630052833.GB2831@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1466948893-11887-1-git-send-email-jianfeng.tan@intel.com>
On Sun, Jun 26, 2016 at 01:48:13PM +0000, Jianfeng Tan wrote:
> Implicit int to enum conversion is not allowed when icc is used as
> the compiler. It raises the compiling error like,
> /.../dpdk/drivers/net/virtio/virtio_user/vhost_user.c(257):
> error #188: enumerated type mixed with another type
> msg.request = req;
> ^
>
> The fix is simple, change the type of parameter req to enum
> vhost_user_request.
>
> Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer")
>
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Applied to dpdk-next-virtio, with the title changed to:
net/virtio-user: fix build error with icc
Thanks.
--yliu
prev parent reply other threads:[~2016-06-30 5:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 7:40 [dpdk-dev] [PATCH] " Jianfeng Tan
2016-06-23 20:51 ` Stephen Hemminger
2016-06-24 0:51 ` Tan, Jianfeng
2016-06-26 13:48 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2016-06-30 5:28 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630052833.GB2831@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).