From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6364C29D6 for ; Thu, 30 Jun 2016 07:42:46 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 29 Jun 2016 22:42:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,550,1459839600"; d="scan'208";a="1012537561" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 29 Jun 2016 22:42:45 -0700 Date: Thu, 30 Jun 2016 13:43:15 +0800 From: Yuanhan Liu To: Jerin Jacob Cc: Jianbo Liu , dev@dpdk.org, Thomas Monjalon , Bruce Richardson , huawei.xie@intel.com Message-ID: <20160630054315.GE2831@yliu-dev.sh.intel.com> References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com> <1467028448-8914-4-git-send-email-jerin.jacob@caviumnetworks.com> <20160629112744.GB5301@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160629112744.GB5301@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/4] virtio: move SSE based Rx implementation to separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 05:42:46 -0000 On Wed, Jun 29, 2016 at 04:57:46PM +0530, Jerin Jacob wrote: > On Tue, Jun 28, 2016 at 02:17:41PM +0800, Jianbo Liu wrote: > > On 27 June 2016 at 19:54, Jerin Jacob wrote: > > > split out SSE instruction based virtio simple rx > > > implementation to a separate file > > > > > > Signed-off-by: Jerin Jacob > > > --- > > > drivers/net/virtio/virtio_rxtx_simple.c | 166 +------------------- > > > drivers/net/virtio/virtio_rxtx_simple_sse.h | 225 ++++++++++++++++++++++++++++ > > > 2 files changed, 226 insertions(+), 165 deletions(-) > > > create mode 100644 drivers/net/virtio/virtio_rxtx_simple_sse.h > > > > > I think it's better to move sse implementation to a C file, > > as Bruce pointed out at > > http://www.dpdk.org/ml/archives/dev/2016-April/037937.html > > I can move to C file, That would call for further restructuring of the code > by Introducing a new file drivers/net/virtio/virtio_rxtx_simple.h and > moving all static inline functions of virtio_rxtx_simple.c so that > virtio_rxtx_simple_sse.c and virtio_rxtx_simple_neon.c can include it. > > Huawei,Yuanhan,All, > > Are you OK with above restructuring? Yes, I think that's better. --yliu