From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 025221C52
 for <dev@dpdk.org>; Fri,  1 Jul 2016 04:05:18 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga103.jf.intel.com with ESMTP; 30 Jun 2016 19:05:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,554,1459839600"; d="scan'208";a="727687873"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by FMSMGA003.fm.intel.com with ESMTP; 30 Jun 2016 19:05:17 -0700
Date: Fri, 1 Jul 2016 10:05:57 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, huawei.xie@intel.com,
 thomas.monjalon@6wind.com
Message-ID: <20160701020557.GN2831@yliu-dev.sh.intel.com>
References: <1467170406-137615-1-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467170406-137615-1-git-send-email-jianfeng.tan@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix missing default macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2016 02:05:19 -0000

On Wed, Jun 29, 2016 at 03:20:06AM +0000, Jianfeng Tan wrote:
> With current config structure, all configuration parameters put into
> common_base with a default value, and overwritten in environment file
> if required, CONFIG_RTE_VIRTIO_USER is missing in common_base.
> 
> This fix is simple, by adding CONFIG_RTE_VIRTIO_USER=n as the default
> macro value.
> 
> Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  config/common_base | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index 5d9daf5..0368d59 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -269,6 +269,11 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
>  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
>  
>  #
> +# Compile software VIRTIO-USER PMD driver

I will not call it "PMD driver", instead, I'd say "virtio device
emulation inside virtio PMD".

Fixed and applied to dpdk-next-virtio.

	--yliu

> +#
> +CONFIG_RTE_VIRTIO_USER=n
> +
> +#
>  # Compile burst-oriented VMXNET3 PMD driver
>  #
>  CONFIG_RTE_LIBRTE_VMXNET3_PMD=y
> -- 
> 2.1.4