From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 4D9902142
 for <dev@dpdk.org>; Fri,  1 Jul 2016 04:15:13 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 30 Jun 2016 19:15:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,555,1459839600"; d="scan'208";a="1008644042"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga002.jf.intel.com with ESMTP; 30 Jun 2016 19:15:11 -0700
Date: Fri, 1 Jul 2016 10:15:51 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com, john.mcnamara@intel.com
Message-ID: <20160701021551.GP2831@yliu-dev.sh.intel.com>
References: <1467191137-65087-1-git-send-email-jianfeng.tan@intel.com>
 <1467191137-65087-2-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467191137-65087-2-git-send-email-jianfeng.tan@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not
	checked
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2016 02:15:13 -0000

On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
> -	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
> -		rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> -				   &get_integer_arg, &cq);
> +	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
> +		ret = rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> +					 &get_integer_arg, &cq);
> +		if (ret < 0) {
> +			PMD_INIT_LOG(ERR, "error to parse %s",
> +				     VIRTIO_USER_ARG_CQ_NUM);
> +			goto end;
> +		}
> +	}
>  	else if (queues > 1)

Above 2 lines should be in one line. Fixed, and series applied to
dpdk-next-virtio.

Thanks.

	--yliu