From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 42A922C2B
 for <dev@dpdk.org>; Mon,  4 Jul 2016 04:23:32 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 03 Jul 2016 19:23:31 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,572,1459839600"; d="scan'208";a="1014940328"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2016 19:23:30 -0700
Date: Mon, 4 Jul 2016 10:24:41 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Rich Lane <rich.lane@bigswitch.com>
Cc: dev@dpdk.org, Tetsuya Mukawa <mukawa@igel.co.jp>
Message-ID: <20160704022441.GS2831@yliu-dev.sh.intel.com>
References: <1467390672-80701-1-git-send-email-rich.lane@bigswitch.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467390672-80701-1-git-send-email-rich.lane@bigswitch.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] vhost: reset queue state in destroy_device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2016 02:23:32 -0000

On Fri, Jul 01, 2016 at 09:31:12AM -0700, Rich Lane wrote:
> Fixes a bug where rte_eth_vhost_get_queue_event would not return enabled queues
> after a guest application restart.
> 
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> Signed-off-by: Rich Lane <rich.lane@bigswitch.com>

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Just some minor comments about the title (nothing big deal; it's just
some DPDK preferences):

- a bug fix patch need be titled as "fix ..."

- it's better to hide specific function in the title. If you run
  "scripts/check-git-log.sh", you will find a warning.

- the prefix should be "net/vhost".

So, I'd like to reword the title a bit, to something like:

    "net/vhost: fix queue state not reset on destroy"

If have no objection, I could fix it while apply.

	--yliu