From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0393D29C7 for ; Mon, 4 Jul 2016 04:59:03 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 03 Jul 2016 19:59:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,572,1459839600"; d="scan'208";a="1010294824" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 03 Jul 2016 19:59:02 -0700 Date: Mon, 4 Jul 2016 11:00:13 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, huawei.xie@intel.com Message-ID: <20160704030013.GU2831@yliu-dev.sh.intel.com> References: <1467363031-106737-1-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467363031-106737-1-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix failure without hints X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2016 02:59:04 -0000 On Fri, Jul 01, 2016 at 08:50:31AM +0000, Jianfeng Tan wrote: > When the specified cores and memory lie on different numa socket with > physical NIC, vhost fails to set up rx queue, and exits without any > hints. This could leads to confusion of users. > > This patch fixes it by adding some error messages when calling ether > APIs returns errors. > > Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") I will not call it a "fix", instead, it's an "enhancement" to me. > Reported-by: Yulong Pei And since it's not a bug, it might be "Suggested-by: ...". --yliu