From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8C1A037A4 for ; Tue, 5 Jul 2016 11:11:51 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 05 Jul 2016 02:11:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,579,1459839600"; d="scan'208";a="1011109050" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.53]) by orsmga002.jf.intel.com with SMTP; 05 Jul 2016 02:11:47 -0700 Received: by (sSMTP sendmail emulation); Tue, 05 Jul 2016 10:11:47 +0025 Date: Tue, 5 Jul 2016 10:11:46 +0100 From: Bruce Richardson To: "Ananyev, Konstantin" Cc: Olivier Matz , "dev@dpdk.org" , "Zhang, Helin" , "amint@icsi.berkeley.edu" Message-ID: <20160705091146.GB10232@bricha3-MOBL3> References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> <1467360147-19571-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B789B0@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2601191342CEEE43887BDE71AB97725836B789B0@irsmsx105.ger.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix compilation when offload flags disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 09:11:51 -0000 On Fri, Jul 01, 2016 at 10:02:46AM +0100, Ananyev, Konstantin wrote: > > > The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n > > because the macro has not the proper number of parameters. To reproduce > > the issue: > > > > make config T=x86_64-native-linuxapp-gcc > > sed -i 's,CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y,CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n,' build/.config > > make -j4 > > [...] > > ixgbe_rxtx_vec_sse.c: In function ‘_recv_raw_pkts_vec’: > > ixgbe_rxtx_vec_sse.c:345:53: error: macro "desc_to_olflags_v" passed 3 arguments, but takes just 2 > > desc_to_olflags_v(descs, vlan_flags, &rx_pkts[pos]); > > ^ > > ixgbe_rxtx_vec_sse.c:345:3: error: ‘desc_to_olflags_v’ undeclared (first use in this function) > > desc_to_olflags_v(descs, vlan_flags, &rx_pkts[pos]); > > ^ > > ixgbe_rxtx_vec_sse.c:345:3: note: each undeclared identifier is reported only once for each function it appears in > > ixgbe_rxtx_vec_sse.c:231:10: error: variable ‘vlan_flags’ set but not used [-Werror=unused-but-set-variable] > > uint8_t vlan_flags; > > ^ > > cc1: all warnings being treated as errors > > > > This patch fixes the number of arguments in th macro, and ensure that > > vlan_flags is marked as used to avoid the third error. > > > > Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") > > Reported-by: Amin Tootoonchian > > Signed-off-by: Olivier Matz > > --- > > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > > index 4f95deb..1c4fd7c 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > > @@ -197,7 +197,9 @@ desc_to_olflags_v(__m128i descs[4], uint8_t vlan_flags, > > rx_pkts[3]->ol_flags = vol.e[3]; > > } > > #else > > -#define desc_to_olflags_v(desc, rx_pkts) do {} while (0) > > +#define desc_to_olflags_v(desc, vlan_flags, rx_pkts) do { \ > > + RTE_SET_USED(vlan_flags); \ > > + } while (0) > > #endif > > > > /* > > -- > > Acked-by: Konstantin Ananyev > Applied to dpdk-next-net/rel_16_07 /Bruce