From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 745385687
 for <dev@dpdk.org>; Tue,  5 Jul 2016 13:29:56 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga104.fm.intel.com with ESMTP; 05 Jul 2016 04:29:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,579,1459839600"; d="scan'208";a="134074552"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga004.fm.intel.com with ESMTP; 05 Jul 2016 04:29:53 -0700
Date: Tue, 5 Jul 2016 19:31:19 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xie, Huawei" <huawei.xie@intel.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>,
 "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Message-ID: <20160705113119.GH26521@yliu-dev.sh.intel.com>
References: <1467191137-65087-1-git-send-email-jianfeng.tan@intel.com>
 <1467191137-65087-2-git-send-email-jianfeng.tan@intel.com>
 <20160701021551.GP2831@yliu-dev.sh.intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E3610614EA1@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E3610614EA1@SHSMSX103.ccr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not
	checked
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2016 11:29:56 -0000

On Tue, Jul 05, 2016 at 10:14:28AM +0000, Tan, Jianfeng wrote:
> > On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
> > > -	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
> > > -		rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> > > -				   &get_integer_arg, &cq);
> > > +	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
> > > +		ret = rte_kvargs_process(kvlist,
> > VIRTIO_USER_ARG_CQ_NUM,
> > > +					 &get_integer_arg, &cq);
> > > +		if (ret < 0) {
> > > +			PMD_INIT_LOG(ERR, "error to parse %s",
> > > +				     VIRTIO_USER_ARG_CQ_NUM);
> > > +			goto end;
> > > +		}
> > > +	}
> > >  	else if (queues > 1)
> > 
> > Above 2 lines should be in one line. Fixed, and series applied to
> > dpdk-next-virtio.
> 
> Thanks.
> 
> But there's another problem in the commit log: the Coverity defect ID should be "127477, 127478"  instead of "127344, 127478". Can you please help make it right?

Done.

	--yliu