DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jan Medala <jan@semihalf.com>,
	dev@dpdk.org, Alexander Matushevsky <matua@amazon.com>,
	Jakub Palider <jpa@semihalf.com>
Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler
Date: Fri, 8 Jul 2016 14:23:43 +0100	[thread overview]
Message-ID: <20160708132342.GA20808@bricha3-MOBL3> (raw)
In-Reply-To: <577B7539.3000007@intel.com>

On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
> On 6/30/2016 4:04 PM, Jan Medala wrote:
> > Signed-off-by: Alexander Matushevsky <matua@amazon.com>
> > Signed-off-by: Jakub Palider <jpa@semihalf.com>
> > Signed-off-by: Jan Medala <jan@semihalf.com>
> 
> The compilation error to fix is [1], it may be good to add what to fix
> into commit log.
> 
> [1]
> == Build drivers/net/ena
>   CC ena_ethdev.o
> /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): error
> #188: enumerated type mixed with another type
>         struct ena_com_create_io_ctx ctx = { 0 };
>                                              ^
> 
> /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): error
> #188: enumerated type mixed with another type
>         struct ena_com_create_io_ctx ctx = { 0 };
>                                              ^
> ...
> 
> > --- a/drivers/net/ena/ena_ethdev.c
> > +++ b/drivers/net/ena/ena_ethdev.c
> > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,
> >  			      __rte_unused unsigned int socket_id,
> >  			      __rte_unused const struct rte_eth_txconf *tx_conf)
> >  {
> > -	struct ena_com_create_io_ctx ctx = { 0 };
> > +	struct ena_com_create_io_ctx ctx =
> > +		/* policy set to _HOST just to satisfy icc compiler */
> > +		{ ENA_ADMIN_PLACEMENT_POLICY_HOST,
> > +		  ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 };
> 
> Trailing "0" are not required, compiler will take care of them.
> 
Actually, given that this is a structure init and not an array, the trailing 
zeros are actually required, since we are not using C99 designated initializers.
Therefore, I'll leave the zeros in - if anyone wants to convert the format of
the initializers to c99 style later, and remove the trailing zeros then, it can
go as a separate patch. I'll just merge this fix in with patch 1 that introduces
the issue.

/Bruce

  parent reply	other threads:[~2016-07-08 13:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 17:54 [dpdk-dev] [PATCH] ena: Update PMD to cooperate with latest ENA firmware Jan Medala
2016-06-20 16:16 ` Ferruh Yigit
2016-06-21 12:05 ` [dpdk-dev] [PATCH v2 0/6] ena: update " Jan Medala
2016-06-21 12:05   ` [dpdk-dev] [PATCH v2 1/6] ena: update of ENA communication layer Jan Medala
2016-06-21 12:05   ` [dpdk-dev] [PATCH v2 2/6] ena: add debug area and host information Jan Medala
2016-06-21 12:06   ` [dpdk-dev] [PATCH v2 3/6] ena: disable readless communication regarding to HW revision Jan Medala
2016-06-21 12:06   ` [dpdk-dev] [PATCH v2 4/6] ena: allocate coherent memory in node-aware way Jan Medala
2016-06-21 12:06   ` [dpdk-dev] [PATCH v2 5/6] ena: fix memory management issue Jan Medala
2016-06-30 15:04     ` [dpdk-dev] [PATCH v3 0/6] ena: update PMD to cooperate with latest ENA firmware Jan Medala
2016-06-30 15:04       ` [dpdk-dev] [PATCH v3 1/6] ena: update of ENA communication layer Jan Medala
2016-06-30 15:04       ` [dpdk-dev] [PATCH v3 2/6] ena: add debug area and host information Jan Medala
2016-06-30 15:04       ` [dpdk-dev] [PATCH v3 3/6] ena: disable readless communication regarding to HW revision Jan Medala
2016-07-04 15:43         ` Bruce Richardson
2016-07-05 10:02           ` Jan Mędala
2016-07-05 15:47             ` Bruce Richardson
2016-06-30 15:04       ` [dpdk-dev] [PATCH v3 4/6] ena: allocate coherent memory in node-aware way Jan Medala
2016-06-30 15:04       ` [dpdk-dev] [PATCH v3 5/6] ena: fix memory management issue Jan Medala
2016-07-04 16:27         ` Bruce Richardson
2016-07-05 16:13           ` Bruce Richardson
2016-07-05 17:03             ` Jan Mędala
2016-07-05 17:03             ` Jan Mędala
2016-06-30 15:04       ` [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler Jan Medala
2016-07-05  8:52         ` Ferruh Yigit
2016-07-05 16:19           ` Bruce Richardson
2016-07-05 17:03             ` Jan Mędala
2016-07-05 17:04               ` Jan Mędala
2016-07-05 17:10                 ` Jan Mędala
2016-07-06  8:14                   ` Bruce Richardson
2016-07-06  8:50                     ` Jan Mędala
2016-07-08 13:23           ` Bruce Richardson [this message]
2016-07-08 14:07             ` Ferruh Yigit
2016-07-08 13:24       ` [dpdk-dev] [PATCH v3 0/6] ena: update PMD to cooperate with latest ENA firmware Bruce Richardson
2016-06-21 12:06   ` [dpdk-dev] [PATCH v2 6/6] ena: fix for icc compiler Jan Medala
2016-06-24 11:52   ` [dpdk-dev] [PATCH v2 0/6] ena: update PMD to cooperate with latest ENA firmware Bruce Richardson
2016-06-29 11:01     ` Bruce Richardson
2016-06-29 11:31       ` Jan Mędala
2016-06-29 12:28         ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708132342.GA20808@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jan@semihalf.com \
    --cc=jpa@semihalf.com \
    --cc=matua@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).