From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 43E135A26 for ; Fri, 8 Jul 2016 15:23:47 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 08 Jul 2016 06:23:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,330,1464678000"; d="scan'208";a="135915753" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.114]) by fmsmga004.fm.intel.com with SMTP; 08 Jul 2016 06:23:44 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Jul 2016 14:23:43 +0025 Date: Fri, 8 Jul 2016 14:23:43 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Jan Medala , dev@dpdk.org, Alexander Matushevsky , Jakub Palider Message-ID: <20160708132342.GA20808@bricha3-MOBL3> References: <1466510763-19569-6-git-send-email-jan@semihalf.com> <1467299099-32498-1-git-send-email-jan@semihalf.com> <1467299099-32498-7-git-send-email-jan@semihalf.com> <577B7539.3000007@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577B7539.3000007@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 13:23:47 -0000 On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > On 6/30/2016 4:04 PM, Jan Medala wrote: > > Signed-off-by: Alexander Matushevsky > > Signed-off-by: Jakub Palider > > Signed-off-by: Jan Medala > > The compilation error to fix is [1], it may be good to add what to fix > into commit log. > > [1] > == Build drivers/net/ena > CC ena_ethdev.o > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): error > #188: enumerated type mixed with another type > struct ena_com_create_io_ctx ctx = { 0 }; > ^ > > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): error > #188: enumerated type mixed with another type > struct ena_com_create_io_ctx ctx = { 0 }; > ^ > ... > > > --- a/drivers/net/ena/ena_ethdev.c > > +++ b/drivers/net/ena/ena_ethdev.c > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev, > > __rte_unused unsigned int socket_id, > > __rte_unused const struct rte_eth_txconf *tx_conf) > > { > > - struct ena_com_create_io_ctx ctx = { 0 }; > > + struct ena_com_create_io_ctx ctx = > > + /* policy set to _HOST just to satisfy icc compiler */ > > + { ENA_ADMIN_PLACEMENT_POLICY_HOST, > > + ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 }; > > Trailing "0" are not required, compiler will take care of them. > Actually, given that this is a structure init and not an array, the trailing zeros are actually required, since we are not using C99 designated initializers. Therefore, I'll leave the zeros in - if anyone wants to convert the format of the initializers to c99 style later, and remove the trailing zeros then, it can go as a separate patch. I'll just merge this fix in with patch 1 that introduces the issue. /Bruce