From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7088F8E6E for ; Fri, 8 Jul 2016 23:00:53 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 08 Jul 2016 14:00:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,332,1464678000"; d="scan'208";a="842984409" Received: from ahaldar-mobl.ger.corp.intel.com ([10.252.24.62]) by orsmga003.jf.intel.com with SMTP; 08 Jul 2016 14:00:50 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Jul 2016 22:00:50 +0025 Date: Fri, 8 Jul 2016 22:00:49 +0100 From: Bruce Richardson To: Nelson Escobar Cc: dev@dpdk.org Message-ID: <20160708210049.GF34980@bricha3-MOBL3> References: <1467940221-11341-1-git-send-email-neescoba@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467940221-11341-1-git-send-email-neescoba@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/2] net/enic: fix setting MAC address when a port is restarted X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 21:00:53 -0000 On Thu, Jul 07, 2016 at 06:10:21PM -0700, Nelson Escobar wrote: > enic_disable() removed the MAC address when a port was shut down but > enic_enable() didn't add the MAC address back when the port was > started again. Move where we set the MAC address for the adapter from > enic_setup_finish() to a enic_enable() so that port restarting works > properly. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley > --- Patchset applied to dpdk-next-net/rel_16_07 /Bruce