From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix failure without hints
Date: Mon, 11 Jul 2016 10:07:57 +0800 [thread overview]
Message-ID: <20160711020757.GU26521@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160704030013.GU2831@yliu-dev.sh.intel.com>
On Mon, Jul 04, 2016 at 11:00:13AM +0800, Yuanhan Liu wrote:
> On Fri, Jul 01, 2016 at 08:50:31AM +0000, Jianfeng Tan wrote:
> > When the specified cores and memory lie on different numa socket with
> > physical NIC, vhost fails to set up rx queue, and exits without any
> > hints. This could leads to confusion of users.
> >
> > This patch fixes it by adding some error messages when calling ether
> > APIs returns errors.
> >
> > Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
>
> I will not call it a "fix", instead, it's an "enhancement" to me.
>
> > Reported-by: Yulong Pei <yulong.pei@intel.com>
>
> And since it's not a bug, it might be "Suggested-by: ...".
Applied to dpdk-next-virtio, with some commit log rewords.
Thanks.
--yliu
prev parent reply other threads:[~2016-07-11 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 8:50 Jianfeng Tan
2016-07-04 3:00 ` Yuanhan Liu
2016-07-11 2:07 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711020757.GU26521@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).