From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A69E12B91 for ; Mon, 11 Jul 2016 07:31:05 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 10 Jul 2016 22:31:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,345,1464678000"; d="scan'208";a="843920471" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 10 Jul 2016 22:31:02 -0700 Date: Mon, 11 Jul 2016 13:33:26 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , stephen@networkplumber.org, bruce.richardson@intel.com, nhorman@tuxdriver.com, pmatilai@redhat.com, christian.ehrhardt@canonical.com, Wenzhuo Lu , ferruh.yigit@intel.com, Rasesh Mody , johndale@cisco.om, Yong Wang Message-ID: <20160711053326.GW26521@yliu-dev.sh.intel.com> References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com> <1461156236-25349-1-git-send-email-david.marchand@6wind.com> <1461156236-25349-2-git-send-email-david.marchand@6wind.com> <2858831.tSF8KXeB50@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2858831.tSF8KXeB50@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 05:31:06 -0000 On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote: > 2016-04-20 14:43, David Marchand: > > test application and kni still want to know e1000 pci devices. > > So let's create headers in the driver that will be used by them. > > There is also an usage of ixgbe ID for the broken bypass API. > > Sharing those PCI ids outside of the drivers was really a wrong idea. > So this a plan to get rid of them: > > 1/ remove need in PCI autotest (done: http://dpdk.org/commit/1dbba165) > 2/ move PCI ids in bnx2x, bnxt, e1000, enic, fm10k, i40e, virtio, vmxnet3 > 3/ remove KNI ethtool (only igb/ixgbe support) > 4/ remove bypass API or move it to ixgbe specific API > 5/ move remaining PCI ids in igb and ixgbe drivers > > Please driver maintainers, move your PCI ids in your drivers as soon as > possible. Thanks Hi Thomas, I'm not quite sure I understood it well: are you asking us to resend what David has already send, say me for resending the virtio part? If so, what's the point of that? What's worse, it's likely to fail apply (due to conflicts), as every one of us make a patch based on the same base while touching some same files. --yliu