From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 745675477 for ; Fri, 15 Jul 2016 17:56:20 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 15 Jul 2016 08:56:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,368,1464678000"; d="scan'208";a="995990636" Received: from unknown ([10.252.22.155]) by orsmga001.jf.intel.com with SMTP; 15 Jul 2016 08:56:16 -0700 Received: by (sSMTP sendmail emulation); Fri, 15 Jul 2016 16:56:16 +0025 Date: Fri, 15 Jul 2016 16:56:15 +0100 From: Bruce Richardson To: Chas Williams <3chas3@gmail.com> Cc: dev@dpdk.org, harish.patil@qlogic.com Message-ID: <20160715155615.GB51144@bricha3-MOBL3> References: <1468330694-383-2-git-send-email-3chas3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468330694-383-2-git-send-email-3chas3@gmail.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 15:56:20 -0000 On Tue, Jul 12, 2016 at 09:38:06AM -0400, Chas Williams wrote: > ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined. Remove them > along with enumeration constants dependent on their inclusion. > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Chas Williams <3chas3@gmail.com> Hi Chas, the threading on this submission is very awkward - poor patch 1 got somehow separated from the rest of it's patch family. :-) Besides this, given where we are in the release cycle for 16.07, these cleanups are being deferred for possible inclusion in 16.11 (once reviewed and acked, obviously). To get cleanup like this in in future release, please submit by the integration deadline date. BTW: If there are any critical bug fixes in this set, please sent them as separate patches clearing calling them out as fixes, so they can get the attention and review they deserve. Thanks, /Bruce