From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5F53F376C for ; Wed, 20 Jul 2016 03:05:06 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 19 Jul 2016 18:04:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,391,1464678000"; d="scan'208";a="998671662" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 19 Jul 2016 18:04:40 -0700 Date: Wed, 20 Jul 2016 09:08:35 +0800 From: Yuanhan Liu To: "Mcnamara, John" Cc: "dev@dpdk.org" , Thomas Monjalon Message-ID: <20160720010835.GO5146@yliu-dev.sh.intel.com> References: <1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 01:05:06 -0000 On Tue, Jul 19, 2016 at 01:57:11PM +0000, Mcnamara, John wrote: > > - Note: the "reconnect" feature requires **QEMU v2.7** (or above). > > + .. Note:: > > + * The "reconnect" feature requires **QEMU v2.7** (or above). > > + > > + * The vhost supported features must be exactly the same before and > > + after the restart. For example, if TSO is disabled and then > > enabled, > > + nothing will work and issues undefined might happen. > > s/ issues undefined / undefined issues / Thomas, mind to fix it while apply? > Apart from that: > > Acked-by: John McNamara Thanks! --yliu