From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, jianfeng.tan@intel.com, huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH] virtio: fix packet corruption
Date: Thu, 21 Jul 2016 16:28:51 +0800 [thread overview]
Message-ID: <20160721082851.GC28708@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1468931519-7381-1-git-send-email-olivier.matz@6wind.com>
On Tue, Jul 19, 2016 at 02:31:59PM +0200, Olivier Matz wrote:
> The support of virtio-user changed the way the mbuf dma address is
> retrieved, using a physical address in case of virtio-pci and a virtual
> address in case of virtio-user.
>
> This change introduced some possible memory corruption in packets,
> replacing:
> m->buf_physaddr + RTE_PKTMBUF_HEADROOM
> by:
> m->buf_physaddr + m->data_off (through a macro)
>
> This patch fixes this issue, restoring the original behavior.
>
> By the way, it also rework the macros, adding a "VIRTIO_" prefix and
> API comments.
>
> Fixes: f24f8f9fee8a ("net/virtio: allow virtual address to fill vring descriptors")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Thanks for the fix!
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
--yliu
next prev parent reply other threads:[~2016-07-21 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 12:31 Olivier Matz
2016-07-19 13:03 ` Tan, Jianfeng
2016-07-19 13:11 ` Olivier Matz
2016-07-19 13:57 ` Tan, Jianfeng
2016-07-19 13:59 ` Olivier Matz
2016-07-19 14:23 ` Tan, Jianfeng
2016-07-21 8:28 ` Yuanhan Liu [this message]
2016-07-21 22:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721082851.GC28708@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).